Issue 7711004: Re-enable clang for official builders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7711004: Re-enable clang for official builders. (Closed)

Created:
9 years, 4 months ago by kerz_chromium

Modified:
9 years, 4 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Re-enable clang for official builders. Revert 96424 - mac: Use gcc for official builds again until breakpad is sorted out. BUG=91371 TEST=none Review URL: http://codereview.chromium.org/7623021 TBR=thakis@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97670

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	build/common.gypi	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nico

9 years, 4 months ago (2011-08-22 17:17:22 UTC) #2

LGTM (assuming you revert the master config change as well)

On Mon, Aug 22, 2011 at 10:15 AM,  <kerz@chromium.org> wrote:
> Reviewers: Nico,
>
> Description:
> Re-enable clang for official builders.
>
> Revert 96424 - mac: Use gcc for official builds again until breakpad is
> sorted
> out.
>
> BUG=91371
> TEST=none
>
> Review URL: http://codereview.chromium.org/7623021
>
> TBR=thakis@chromium.org
>
> Please review this at http://codereview.chromium.org/7711004/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     build/common.gypi
>
>
> Index: build/common.gypi
> ===================================================================
> --- build/common.gypi   (revision 97669)
> +++ build/common.gypi   (working copy)
> @@ -578,8 +578,7 @@
>             # here (it was added after the m14 branch was cut). This is in
> the
>             # buildtype=="Official" section so that developers don't see it
>             # for their local builds.
> -            # TODO(thakis): Reenable once breakpad issues are sorted out.
> -            #'clang%': 1,
> +            'clang%': 1,
>           }, { # else: branding!="Chrome" or buildtype!="Official"
>             'mac_breakpad%': 0,
>             'mac_keystone%': 0,
>
>
>

Expand Messages | Collapse Messages