Issue 7623021: mac: Use gcc for official builds again until breakpad is sorted out.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7623021: mac: Use gcc for official builds again until breakpad is sorted out. (Closed)

Created:
9 years, 4 months ago by Nico

Modified:
9 years, 4 months ago

Reviewers:
kerz_chromium

CC:
chromium-reviews, Mark Mentovai

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

mac: Use gcc for official builds again until breakpad is sorted out. BUG=91371 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96424

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	build/common.gypi	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kerz_chromium

9 years, 4 months ago (2011-08-11 18:08:26 UTC) #2

LGTM

On Thu, Aug 11, 2011 at 11:07 AM, <thakis@chromium.org> wrote:

> Reviewers: kerz_chromium,
>
> Description:
> mac: Use gcc for official builds again until breakpad is sorted out.
>
> BUG=91371
> TEST=none
>
>
> Please review this at
http://codereview.chromium.**org/7623021/<http://codereview.chromium.org/7623...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M build/common.gypi
>
>
> Index: build/common.gypi
> diff --git a/build/common.gypi b/build/common.gypi
> index 5229980dcea3bbfb130063f7513aae**d3844d5809..**
> e807099727af5fcebf1fda215e880a**e4cccf114b 100644
> --- a/build/common.gypi
> +++ b/build/common.gypi
> @@ -564,7 +564,8 @@
>             # here (it was added after the m14 branch was cut). This is in
> the
>             # buildtype=="Official" section so that developers don't see it
>             # for their local builds.
> -            'clang%': 1,
> +            # TODO(thakis): Reenable once breakpad issues are sorted out.
> +            #'clang%': 1,
>           }, { # else: branding!="Chrome" or buildtype!="Official"
>             'mac_breakpad%': 0,
>             'mac_keystone%': 0,
>
>
>

Expand Messages | Collapse Messages