Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 7708021: content: Move render_widget_host_view_gtk to content/ try 2. (Closed)

Created:
9 years, 4 months ago by Elliot Glaysher
Modified:
9 years, 4 months ago
CC:
chromium-reviews, asanka, Avi (use Gerrit), Erik does not do reviews, brettw-cc_chromium.org, jam, mihaip+watch_chromium.org, Randy Smith (Not in Mondays), joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, Paweł Hajdan Jr., jshin+watch_chromium.org
Visibility:
Public.

Description

content: Move render_widget_host_view_gtk to content/ try 2. This was r97750, which was reverted at r97756. This patch, in addition to all the other things it did, marks OwnedWidgetGtk for export and moves it to the ui:: namespace. Original list of things this patch does: - OwnedWidgetGtk now goes in ui/base/gtk/ - TruncateString moved from l10n_util:: to ui:: - GtkIMContextWrapper has part of its code split into chrome/ (IDC using code goes in RenderViewContextMenu) and the rest go in content/ (gtk using code goes with GtkIMContextWrapper). - gtk_key_bindings_handler[_unittest] now goes in content, as it's a utility class to RenderWidgetHostGtk. BUG=93804 TEST=existing unit tests Original Review URL: http://codereview.chromium.org/7669040 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97889

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+346 lines, -3519 lines) Patch
M chrome/browser/extensions/extension_menu_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/renderer_host/gtk_im_context_wrapper.h View 1 chunk +0 lines, -200 lines 0 comments Download
D chrome/browser/renderer_host/gtk_im_context_wrapper.cc View 1 chunk +0 lines, -642 lines 0 comments Download
D chrome/browser/renderer_host/gtk_key_bindings_handler.h View 1 chunk +0 lines, -128 lines 0 comments Download
D chrome/browser/renderer_host/gtk_key_bindings_handler.cc View 1 chunk +0 lines, -325 lines 0 comments Download
D chrome/browser/renderer_host/gtk_key_bindings_handler_unittest.cc View 1 chunk +0 lines, -220 lines 0 comments Download
D chrome/browser/renderer_host/render_widget_host_view_gtk.h View 1 chunk +0 lines, -277 lines 0 comments Download
D chrome/browser/renderer_host/render_widget_host_view_gtk.cc View 1 chunk +0 lines, -1209 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_views.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_win.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/speech/speech_input_bubble_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_gtk.cc View 2 chunks +25 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_gtk.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_gtk.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.h View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_utils_gtk.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/browser_actions_toolbar_gtk.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_toolbar_gtk.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/constrained_window_gtk.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/custom_button.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/download/download_item_gtk.h View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/download/download_shelf_gtk.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_popup_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/find_bar_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/fullscreen_exit_bubble_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/global_bookmark_menu.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/global_history_menu.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/global_history_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/global_menu_bar.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_theme_service.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_util.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/infobars/infobar_container_gtk.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/infobars/infobar_gtk.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.h View 6 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/gtk/notifications/balloon_view_host_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.h View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/overflow_button.h View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/ui/gtk/owned_widget_gtk.h View 1 chunk +0 lines, -91 lines 0 comments Download
D chrome/browser/ui/gtk/owned_widget_gtk.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M chrome/browser/ui/gtk/profile_menu_button.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/reload_button_gtk.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/sad_tab_gtk.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/slide_animator_gtk.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/ssl_client_certificate_selector.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/status_bubble_gtk.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/tab_contents_container_gtk.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/tab_contents_container_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_renderer_gtk.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_strip_gtk.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/login/login_prompt_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/location_bar_util.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/notifications/balloon_view_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 5 chunks +0 lines, -14 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/test/data/gtk_key_bindings_test_gtkrc View 1 chunk +0 lines, -83 lines 0 comments Download
A + content/browser/renderer_host/gtk_im_context_wrapper.h View 4 chunks +4 lines, -7 lines 0 comments Download
A + content/browser/renderer_host/gtk_im_context_wrapper.cc View 3 chunks +4 lines, -27 lines 0 comments Download
A + content/browser/renderer_host/gtk_key_bindings_handler.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + content/browser/renderer_host/gtk_key_bindings_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/renderer_host/gtk_key_bindings_handler_unittest.cc View 3 chunks +6 lines, -4 lines 0 comments Download
A + content/browser/renderer_host/render_widget_host_view_gtk.h View 5 chunks +6 lines, -10 lines 0 comments Download
A + content/browser/renderer_host/render_widget_host_view_gtk.cc View 7 chunks +18 lines, -17 lines 0 comments Download
M content/common/content_paths.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/common/content_paths.cc View 2 chunks +16 lines, -1 line 0 comments Download
M content/common/content_switches.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/common/content_switches.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 3 chunks +20 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 3 chunks +7 lines, -0 lines 0 comments Download
M content/test/content_test_suite.cc View 2 chunks +5 lines, -0 lines 0 comments Download
A + content/test/data/gtk_key_bindings_test_gtkrc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/base/gtk/owned_widget_gtk.h View 2 chunks +9 lines, -4 lines 0 comments Download
A + ui/base/gtk/owned_widget_gtk.cc View 2 chunks +5 lines, -1 line 0 comments Download
M ui/base/l10n/l10n_util.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/base/l10n/l10n_util.cc View 1 chunk +0 lines, -63 lines 0 comments Download
M ui/base/l10n/l10n_util_unittest.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M ui/base/text/text_elider.h View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/base/text/text_elider.cc View 3 chunks +66 lines, -0 lines 0 comments Download
M ui/base/text/text_elider_unittest.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M ui/ui.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Elliot Glaysher
This is attempt #2. The only difference is OwnedWidgetGtk is now UI_EXPORT and in the ...
9 years, 4 months ago (2011-08-23 00:13:15 UTC) #1
jam
lgtm btw, I find it helpeful when committing reverts to first upload the previous version ...
9 years, 4 months ago (2011-08-23 00:16:00 UTC) #2
commit-bot: I haz the power
Can't process patch for file content/browser/renderer_host/gtk_key_bindings_handler_unittest.cc. A +
9 years, 4 months ago (2011-08-23 17:43:49 UTC) #3
jam
9 years, 4 months ago (2011-08-25 02:15:13 UTC) #4
Hmm, this actually causes a linker error when we try to build content on its own
for views build, i.e. see 
http://build.chromium.org/p/chromium/builders/Linux%20Builder%20%28Views%20db...

the problem is that this code brings in a dependency on
#include "views/widget/tooltip_window_gtk.h"

and so far we've avoided bringing in views to content. let's talk tomorrow with
ben and try to figure out what we should do here

Powered by Google App Engine
This is Rietveld 408576698