Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 7669040: content: Move render_widget_host_view_gtk to content/ (Closed)

Created:
9 years, 4 months ago by Elliot Glaysher
Modified:
9 years, 4 months ago
Reviewers:
Dirk Pranke, jam
CC:
chromium-reviews, asanka, Avi (use Gerrit), Erik does not do reviews, Randy Smith (Not in Mondays), mihaip+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

content: Move render_widget_host_view_gtk to content/ This also moves some other files: - OwnedWidgetGtk now goes in ui/base/gtk/ - TruncateString moved from l10n_util:: to ui:: - GtkIMContextWrapper has part of its code split into chrome/ (IDC using code goes in RenderViewContextMenu) and the rest go in content/ (gtk using code goes with GtkIMContextWrapper). - gtk_key_bindings_handler[_unittest] now goes in content, as it's a utility class to RenderWidgetHostGtk. BUG=93804 TEST=existing unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97750

Patch Set 1 #

Patch Set 2 : Move more functions to satisfy DEPS #

Patch Set 3 : Shot in the dark for windows #

Patch Set 4 : Hopefully fix windows this time #

Patch Set 5 : Mac compile fix + cleanup #

Patch Set 6 : Rebase after phajdan.jr's change #

Patch Set 7 : Reduce duplicate 'conditions' #

Patch Set 8 : Rebase to Monday #

Patch Set 9 : Fix touchui/chromeos #

Patch Set 10 : chromeos fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -3467 lines) Patch
M chrome/browser/extensions/extension_menu_manager.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/renderer_host/gtk_im_context_wrapper.h View 1 chunk +0 lines, -200 lines 0 comments Download
D chrome/browser/renderer_host/gtk_im_context_wrapper.cc View 1 chunk +0 lines, -642 lines 0 comments Download
D chrome/browser/renderer_host/gtk_key_bindings_handler.h View 1 1 chunk +0 lines, -128 lines 0 comments Download
D chrome/browser/renderer_host/gtk_key_bindings_handler.cc View 1 1 chunk +0 lines, -325 lines 0 comments Download
D chrome/browser/renderer_host/gtk_key_bindings_handler_unittest.cc View 1 1 chunk +0 lines, -220 lines 0 comments Download
D chrome/browser/renderer_host/render_widget_host_view_gtk.h View 1 chunk +0 lines, -277 lines 0 comments Download
D chrome/browser/renderer_host/render_widget_host_view_gtk.cc View 1 chunk +0 lines, -1209 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_views.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_win.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/speech/speech_input_bubble_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_gtk.cc View 2 chunks +25 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_gtk.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_utils_gtk.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/browser_actions_toolbar_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_toolbar_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/constrained_window_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/custom_button.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/download/download_item_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/download/download_shelf_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_popup_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/find_bar_gtk.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/global_bookmark_menu.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/global_history_menu.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/global_history_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/global_menu_bar.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/gtk_theme_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/gtk_util.cc View 1 2 3 4 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/infobars/infobar_container_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/infobars/infobar_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/notifications/balloon_view_host_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/overflow_button.h View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/gtk/owned_widget_gtk.h View 1 chunk +0 lines, -91 lines 0 comments Download
D chrome/browser/ui/gtk/owned_widget_gtk.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M chrome/browser/ui/gtk/profile_menu_button.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/reload_button_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/sad_tab_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/slide_animator_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/ssl_client_certificate_selector.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/status_bubble_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tab_contents_container_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tab_contents_container_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_renderer_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_strip_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/location_bar_util.cc View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_view.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/notifications/balloon_view_host.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_view_gtk.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 5 chunks +0 lines, -14 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 7 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/test/data/gtk_key_bindings_test_gtkrc View 1 1 chunk +0 lines, -83 lines 0 comments Download
A + content/browser/renderer_host/gtk_im_context_wrapper.h View 4 chunks +4 lines, -7 lines 0 comments Download
A + content/browser/renderer_host/gtk_im_context_wrapper.cc View 3 chunks +4 lines, -27 lines 0 comments Download
A + content/browser/renderer_host/gtk_key_bindings_handler.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/renderer_host/gtk_key_bindings_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/renderer_host/gtk_key_bindings_handler_unittest.cc View 1 2 3 4 5 6 7 3 chunks +5 lines, -3 lines 0 comments Download
A + content/browser/renderer_host/render_widget_host_view_gtk.h View 4 chunks +5 lines, -9 lines 0 comments Download
A + content/browser/renderer_host/render_widget_host_view_gtk.cc View 1 7 chunks +18 lines, -17 lines 0 comments Download
M content/common/content_paths.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/common/content_paths.cc View 1 2 chunks +16 lines, -1 line 0 comments Download
M content/common/content_switches.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/common/content_switches.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 3 chunks +20 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 6 2 chunks +6 lines, -0 lines 0 comments Download
M content/test/content_test_suite.cc View 1 2 3 4 5 2 chunks +5 lines, -0 lines 0 comments Download
A + content/test/data/gtk_key_bindings_test_gtkrc View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/base/gtk/owned_widget_gtk.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/base/gtk/owned_widget_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/l10n/l10n_util.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M ui/base/l10n/l10n_util.cc View 1 1 chunk +0 lines, -63 lines 0 comments Download
M ui/base/l10n/l10n_util_unittest.cc View 1 1 chunk +0 lines, -30 lines 0 comments Download
M ui/base/text/text_elider.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M ui/base/text/text_elider.cc View 1 3 chunks +66 lines, -0 lines 0 comments Download
M ui/base/text/text_elider_unittest.cc View 1 1 chunk +27 lines, -0 lines 0 comments Download
M ui/ui.gyp View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Elliot Glaysher
This patch has already gotten too big. I should have tried moving some of the ...
9 years, 4 months ago (2011-08-22 17:50:06 UTC) #1
jam
On 2011/08/22 17:50:06, Elliot Glaysher wrote: > This patch has already gotten too big. I ...
9 years, 4 months ago (2011-08-22 18:13:13 UTC) #2
Dirk Pranke
gyp changes look fine to me, at least.
9 years, 4 months ago (2011-08-22 19:29:15 UTC) #3
jam
9 years, 4 months ago (2011-08-22 20:07:07 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698