Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 77035: Add ENABLE_DEBUGGER_SUPPORT macro.... (Closed)

Created:
11 years, 8 months ago by Feng Qian
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add ENABLE_DEBUGGER_SUPPORT macro. ENABLE_DEBUGGER_SUPPORT is enabled by default unless it is on Android platform. On Android platform, it can also enabled by passing -DENABLE_DEBUGGER_SUPPORT flag to the compiler. This should not affect any existing build (I hope, cross my fingers) except the build in real Android environment (in other word, it only affects me now). There are lot of room for code refactoring in stead of using #ifdef all over the place. I will leave this to v8 folks. Committed: http://code.google.com/p/v8/source/detail?r=1745

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -110 lines) Patch
M SConstruct View 2 chunks +2 lines, -1 line 0 comments Download
M src/api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/assembler.h View 4 chunks +13 lines, -7 lines 0 comments Download
M src/assembler.cc View 3 chunks +17 lines, -11 lines 0 comments Download
M src/bootstrapper.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M src/builtins.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/builtins.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/builtins-ia32.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/codegen.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/codegen-arm.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/codegen-ia32.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/d8.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/d8.cc View 6 chunks +8 lines, -0 lines 0 comments Download
M src/debug.h View 3 chunks +4 lines, -1 line 0 comments Download
M src/debug.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/debug-agent.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/debug-agent.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/debug-arm.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/debug-ia32.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/execution.h View 2 chunks +7 lines, -4 lines 0 comments Download
M src/execution.cc View 5 chunks +12 lines, -2 lines 0 comments Download
M src/factory.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/factory.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/handles.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/heap.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ic.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ic.cc View 4 chunks +4 lines, -1 line 0 comments Download
M src/ic-inl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/macro-assembler-arm.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/macro-assembler-arm.cc View 4 chunks +6 lines, -1 line 0 comments Download
M src/macro-assembler-ia32.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/macro-assembler-ia32.cc View 6 chunks +6 lines, -1 line 0 comments Download
M src/objects.h View 4 chunks +14 lines, -3 lines 0 comments Download
M src/objects.cc View 7 chunks +8 lines, -1 line 0 comments Download
M src/objects-inl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/runtime.h View 4 chunks +44 lines, -39 lines 0 comments Download
M src/runtime.cc View 5 chunks +24 lines, -21 lines 0 comments Download
M src/serialize.cc View 5 chunks +8 lines, -4 lines 1 comment Download
M src/stub-cache.h View 2 chunks +4 lines, -0 lines 1 comment Download
M src/stub-cache.cc View 4 chunks +4 lines, -0 lines 0 comments Download
M src/top.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/v8.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/v8.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/v8threads.cc View 3 chunks +6 lines, -0 lines 2 comments Download

Messages

Total messages: 2 (0 generated)
Feng Qian
11 years, 8 months ago (2009-04-17 22:42:21 UTC) #1
Søren Thygesen Gjesse
11 years, 8 months ago (2009-04-17 23:46:17 UTC) #2
LGTM

It is nasty with all these #ifdef's, but they are somewhat grouped together. I
will refactor to get rid of them going forward.

You should remember to exclude debug-delay.js and mirror-delay.js when building
without debugger enabled.

http://codereview.chromium.org/77035/diff/1/32
File src/serialize.cc (right):

http://codereview.chromium.org/77035/diff/1/32#newcode683
Line 683: 5,
Why not re-number these?

http://codereview.chromium.org/77035/diff/1/45
File src/stub-cache.h (right):

http://codereview.chromium.org/77035/diff/1/45#newcode297
Line 297: Object* CompileLazyCompile(Code::Flags flags);
Please move this before the #ifdef ENABLE_DEBUGGER_SUPPORT.

http://codereview.chromium.org/77035/diff/1/22
File src/v8threads.cc (right):

http://codereview.chromium.org/77035/diff/1/22#newcode178
Line 178: Debug::ArchiveSpacePerThread() +
Please move this to the bottom of the "list".

http://codereview.chromium.org/77035/diff/1/22#newcode267
Line 267: to = Debug::ArchiveDebug(to);
Please move this to the bottom of the "list".

Powered by Google App Engine
This is Rietveld 408576698