Switching NaCl IRT to be built inside the chrome build.

Switching NaCl IRT to be built inside the chrome build.

Fourth attempt:

Switching IRT to be built inside the chrome build. Dropping the IRT download
step from the DEPS. Step3 of a many step plan to switch where ppapi + irt
are built.
Dropping download_nacl_irt because we no longer rely on a prebuilt copy.
Dropping irt download drop source tarball (assume people using it will have
to download / build their own nacl toolchain).

Old Review URL: http://codereview.chromium.org/7669058
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97987

[noelallen_use_chromium, 2011-08-24 00:21:38]

LGTM (/w TODO)

http://codereview.chromium.org/7701017/diff/2001/chrome/build_nacl_irt.py
File chrome/build_nacl_irt.py (right):

http://codereview.chromium.org/7701017/diff/2001/chrome/build_nacl_irt.py#new...
chrome/build_nacl_irt.py:63: # If things fail on windows, try running --help, if
that fails,
How about returning a specific error code from scons, since this code already
assumes that if scons can't find it, it must not be a builder.
(TODO is OK)

[Dmitry Polukhin, 2011-08-24 11:48:32]

It looks like this CL broke Chrome build inside chroot.


chromeos-chrome-15.0.859.0_rc-r1:
/home/dpolukhin/chrome_root/src/native_client/toolchain/linux_x86_newlib/bin/x86_64-nacl-gcc
-m32 --v -c
chromeos-chrome-15.0.859.0_rc-r1:
/home/dpolukhin/chrome_root/src/native_client/toolchain/linux_x86_newlib/bin/x86_64-nacl-gcc:
/lib32/libc.so.6: version `GLIBC_2.11' not found (required by
/home/dpolukhin/chrome_root/src/native_client/toolchain/linux_x86_newlib/bin/x86_64-nacl-gcc)
chromeos-chrome-15.0.859.0_rc-r1: scons: *** Error 1
chromeos-chrome-15.0.859.0_rc-r1:
/home/dpolukhin/chrome_root/src/native_client/toolchain/linux_x86_newlib/bin/x86_64-nacl-gcc
-m32 -print-search-dirs
chromeos-chrome-15.0.859.0_rc-r1:
/home/dpolukhin/chrome_root/src/native_client/toolchain/linux_x86_newlib/bin/x86_64-nacl-gcc:
/lib32/libc.so.6: version `GLIBC_2.11' not found (required by
/home/dpolukhin/chrome_root/src/native_client/toolchain/linux_x86_newlib/bin/x86_64-nacl-gcc)
chromeos-chrome-15.0.859.0_rc-r1: scons: *** Error 1
chromeos-chrome-15.0.859.0_rc-r1:
/home/dpolukhin/chrome_root/src/native_client/toolchain/linux_x86_newlib/bin/x86_64-nacl-gcc
-m32 -print-libgcc-file-name
chromeos-chrome-15.0.859.0_rc-r1:
/home/dpolukhin/chrome_root/src/native_client/toolchain/linux_x86_newlib/bin/x86_64-nacl-gcc:
/lib32/libc.so.6: version `GLIBC_2.11' not found (required by
/home/dpolukhin/chrome_root/src/native_client/toolchain/linux_x86_newlib/bin/x86_64-nacl-gcc)
chromeos-chrome-15.0.859.0_rc-r1: scons: *** Error 1

...

chromeos-chrome-15.0.859.0_rc-r1: Install file: "src/untrusted/stubs/crt1.x" as
"scons-out/nacl_irt-x86-32/obj/src/untrusted/stubs/crt1.o"
chromeos-chrome-15.0.859.0_rc-r1:
/home/dpolukhin/chrome_root/src/native_client/toolchain/linux_x86_newlib/bin/x86_64-nacl-ar
rc scons-out/nacl_irt-x86-32/obj/src/untrusted/stubs/libcrt_platform.a
chromeos-chrome-15.0.859.0_rc-r1:
/home/dpolukhin/chrome_root/src/native_client/toolchain/linux_x86_newlib/bin/x86_64-nacl-ar:
error while loading shared libraries: libz.so.1: cannot open shared object file:
No such file or directory
chromeos-chrome-15.0.859.0_rc-r1: Install file: "src/shared/platform/nacl_log.h"
as "scons-out/nacl_irt-x86-32/include/nacl/nacl_log.h"
chromeos-chrome-15.0.859.0_rc-r1: Install file:
"src/include/nacl/nacl_inttypes.h" as
"scons-out/nacl_irt-x86-32/include/nacl/nacl_inttypes.h"
chromeos-chrome-15.0.859.0_rc-r1: scons: ***
[scons-out/nacl_irt-x86-32/obj/src/untrusted/stubs/libcrt_platform.a] Error 127
chromeos-chrome-15.0.859.0_rc-r1: scons: building terminated because of errors.

[noelallen_use_chromium, 2011-08-24 17:22:44]

another set of machines to skip building on like win/devenv?
-Noel

On Wed, Aug 24, 2011 at 4:48 AM,  <dpolukhin@chromium.org> wrote:
> It looks like this CL broke Chrome build inside chroot.
>
>
> chromeos-chrome-15.0.859.0_rc-r1:
>
/home/dpolukhin/chrome_root/src/native_client/toolchain/linux_x86_newlib/bin/x86_64-nacl-gcc
> -m32 --v -c
> chromeos-chrome-15.0.859.0_rc-r1:
>
/home/dpolukhin/chrome_root/src/native_client/toolchain/linux_x86_newlib/bin/x86_64-nacl-gcc:
> /lib32/libc.so.6: version `GLIBC_2.11' not found (required by
>
/home/dpolukhin/chrome_root/src/native_client/toolchain/linux_x86_newlib/bin/x86_64-nacl-gcc)
> chromeos-chrome-15.0.859.0_rc-r1: scons: *** Error 1
> chromeos-chrome-15.0.859.0_rc-r1:
>
/home/dpolukhin/chrome_root/src/native_client/toolchain/linux_x86_newlib/bin/x86_64-nacl-gcc
> -m32 -print-search-dirs
> chromeos-chrome-15.0.859.0_rc-r1:
>
/home/dpolukhin/chrome_root/src/native_client/toolchain/linux_x86_newlib/bin/x86_64-nacl-gcc:
> /lib32/libc.so.6: version `GLIBC_2.11' not found (required by
>
/home/dpolukhin/chrome_root/src/native_client/toolchain/linux_x86_newlib/bin/x86_64-nacl-gcc)
> chromeos-chrome-15.0.859.0_rc-r1: scons: *** Error 1
> chromeos-chrome-15.0.859.0_rc-r1:
>
/home/dpolukhin/chrome_root/src/native_client/toolchain/linux_x86_newlib/bin/x86_64-nacl-gcc
> -m32 -print-libgcc-file-name
> chromeos-chrome-15.0.859.0_rc-r1:
>
/home/dpolukhin/chrome_root/src/native_client/toolchain/linux_x86_newlib/bin/x86_64-nacl-gcc:
> /lib32/libc.so.6: version `GLIBC_2.11' not found (required by
>
/home/dpolukhin/chrome_root/src/native_client/toolchain/linux_x86_newlib/bin/x86_64-nacl-gcc)
> chromeos-chrome-15.0.859.0_rc-r1: scons: *** Error 1
>
> ...
>
> chromeos-chrome-15.0.859.0_rc-r1: Install file: "src/untrusted/stubs/crt1.x"
> as
> "scons-out/nacl_irt-x86-32/obj/src/untrusted/stubs/crt1.o"
> chromeos-chrome-15.0.859.0_rc-r1:
>
/home/dpolukhin/chrome_root/src/native_client/toolchain/linux_x86_newlib/bin/x86_64-nacl-ar
> rc scons-out/nacl_irt-x86-32/obj/src/untrusted/stubs/libcrt_platform.a
> chromeos-chrome-15.0.859.0_rc-r1:
>
/home/dpolukhin/chrome_root/src/native_client/toolchain/linux_x86_newlib/bin/x86_64-nacl-ar:
> error while loading shared libraries: libz.so.1: cannot open shared object
> file:
> No such file or directory
> chromeos-chrome-15.0.859.0_rc-r1: Install file:
> "src/shared/platform/nacl_log.h"
> as "scons-out/nacl_irt-x86-32/include/nacl/nacl_log.h"
> chromeos-chrome-15.0.859.0_rc-r1: Install file:
> "src/include/nacl/nacl_inttypes.h" as
> "scons-out/nacl_irt-x86-32/include/nacl/nacl_inttypes.h"
> chromeos-chrome-15.0.859.0_rc-r1: scons: ***
> [scons-out/nacl_irt-x86-32/obj/src/untrusted/stubs/libcrt_platform.a] Error
> 127
> chromeos-chrome-15.0.859.0_rc-r1: scons: building terminated because of
> errors.
>
>
> http://codereview.chromium.org/7701017/
>

[bradn, 2011-08-24 17:27:48]

Hi Dmitry,

I'm concerned that this failed for you (locally?) without making a bot red
somewhere?
Can you give me a little more context?
At a glance it looks like we'll need to enlarge the set of packages in the
chroot.

-BradN



On Wed, Aug 24, 2011 at 4:48 AM, <dpolukhin@chromium.org> wrote:

> It looks like this CL broke Chrome build inside chroot.
>
>
> chromeos-chrome-15.0.859.0_rc-**r1:
> /home/dpolukhin/chrome_root/**src/native_client/toolchain/**
> linux_x86_newlib/bin/x86_64-**nacl-gcc
> -m32 --v -c
> chromeos-chrome-15.0.859.0_rc-**r1:
> /home/dpolukhin/chrome_root/**src/native_client/toolchain/**
> linux_x86_newlib/bin/x86_64-**nacl-gcc:
> /lib32/libc.so.6: version `GLIBC_2.11' not found (required by
> /home/dpolukhin/chrome_root/**src/native_client/toolchain/**
> linux_x86_newlib/bin/x86_64-**nacl-gcc)
> chromeos-chrome-15.0.859.0_rc-**r1: scons: *** Error 1
> chromeos-chrome-15.0.859.0_rc-**r1:
> /home/dpolukhin/chrome_root/**src/native_client/toolchain/**
> linux_x86_newlib/bin/x86_64-**nacl-gcc
> -m32 -print-search-dirs
> chromeos-chrome-15.0.859.0_rc-**r1:
> /home/dpolukhin/chrome_root/**src/native_client/toolchain/**
> linux_x86_newlib/bin/x86_64-**nacl-gcc:
> /lib32/libc.so.6: version `GLIBC_2.11' not found (required by
> /home/dpolukhin/chrome_root/**src/native_client/toolchain/**
> linux_x86_newlib/bin/x86_64-**nacl-gcc)
> chromeos-chrome-15.0.859.0_rc-**r1: scons: *** Error 1
> chromeos-chrome-15.0.859.0_rc-**r1:
> /home/dpolukhin/chrome_root/**src/native_client/toolchain/**
> linux_x86_newlib/bin/x86_64-**nacl-gcc
> -m32 -print-libgcc-file-name
> chromeos-chrome-15.0.859.0_rc-**r1:
> /home/dpolukhin/chrome_root/**src/native_client/toolchain/**
> linux_x86_newlib/bin/x86_64-**nacl-gcc:
> /lib32/libc.so.6: version `GLIBC_2.11' not found (required by
> /home/dpolukhin/chrome_root/**src/native_client/toolchain/**
> linux_x86_newlib/bin/x86_64-**nacl-gcc)
> chromeos-chrome-15.0.859.0_rc-**r1: scons: *** Error 1
>
> ...
>
> chromeos-chrome-15.0.859.0_rc-**r1: Install file:
> "src/untrusted/stubs/crt1.x" as
> "scons-out/nacl_irt-x86-32/**obj/src/untrusted/stubs/crt1.**o"
> chromeos-chrome-15.0.859.0_rc-**r1:
> /home/dpolukhin/chrome_root/**src/native_client/toolchain/**
> linux_x86_newlib/bin/x86_64-**nacl-ar
> rc scons-out/nacl_irt-x86-32/obj/**src/untrusted/stubs/libcrt_**platform.a
> chromeos-chrome-15.0.859.0_rc-**r1:
> /home/dpolukhin/chrome_root/**src/native_client/toolchain/**
> linux_x86_newlib/bin/x86_64-**nacl-ar:
> error while loading shared libraries: libz.so.1: cannot open shared object
> file:
> No such file or directory
> chromeos-chrome-15.0.859.0_rc-**r1: Install file:
> "src/shared/platform/nacl_log.**h"
> as "scons-out/nacl_irt-x86-32/**include/nacl/nacl_log.h"
> chromeos-chrome-15.0.859.0_rc-**r1: Install file:
> "src/include/nacl/nacl_**inttypes.h" as
> "scons-out/nacl_irt-x86-32/**include/nacl/nacl_inttypes.h"
> chromeos-chrome-15.0.859.0_rc-**r1: scons: ***
> [scons-out/nacl_irt-x86-32/**obj/src/untrusted/stubs/**libcrt_platform.a]
> Error 127
> chromeos-chrome-15.0.859.0_rc-**r1: scons: building terminated because of
> errors.
>
>
>
>
http://codereview.chromium.**org/7701017/<http://codereview.chromium.org/7701...
>

[Dmitry Polukhin, 2011-08-24 17:45:27]

It did make bot red but that the bot was on Chrome OS waterfall. Build just
before I reverted your cl:
http://build.chromium.org/p/chromiumos/builders/x86%20generic%20TOT%20chrome%...

Chrome OS bots on Chromium waterfall build Chrome outside chroot.

On Wed, Aug 24, 2011 at 9:27 PM, Bradley Nelson <bradnelson@google.com>wrote:

> Hi Dmitry,
>
> I'm concerned that this failed for you (locally?) without making a bot red
> somewhere?
> Can you give me a little more context?
> At a glance it looks like we'll need to enlarge the set of packages in the
> chroot.
>
> -BradN
>
>
>
> On Wed, Aug 24, 2011 at 4:48 AM, <dpolukhin@chromium.org> wrote:
>
>> It looks like this CL broke Chrome build inside chroot.
>>
>>
>> chromeos-chrome-15.0.859.0_rc-**r1:
>> /home/dpolukhin/chrome_root/**src/native_client/toolchain/**
>> linux_x86_newlib/bin/x86_64-**nacl-gcc
>> -m32 --v -c
>> chromeos-chrome-15.0.859.0_rc-**r1:
>> /home/dpolukhin/chrome_root/**src/native_client/toolchain/**
>> linux_x86_newlib/bin/x86_64-**nacl-gcc:
>> /lib32/libc.so.6: version `GLIBC_2.11' not found (required by
>> /home/dpolukhin/chrome_root/**src/native_client/toolchain/**
>> linux_x86_newlib/bin/x86_64-**nacl-gcc)
>> chromeos-chrome-15.0.859.0_rc-**r1: scons: *** Error 1
>> chromeos-chrome-15.0.859.0_rc-**r1:
>> /home/dpolukhin/chrome_root/**src/native_client/toolchain/**
>> linux_x86_newlib/bin/x86_64-**nacl-gcc
>> -m32 -print-search-dirs
>> chromeos-chrome-15.0.859.0_rc-**r1:
>> /home/dpolukhin/chrome_root/**src/native_client/toolchain/**
>> linux_x86_newlib/bin/x86_64-**nacl-gcc:
>> /lib32/libc.so.6: version `GLIBC_2.11' not found (required by
>> /home/dpolukhin/chrome_root/**src/native_client/toolchain/**
>> linux_x86_newlib/bin/x86_64-**nacl-gcc)
>> chromeos-chrome-15.0.859.0_rc-**r1: scons: *** Error 1
>> chromeos-chrome-15.0.859.0_rc-**r1:
>> /home/dpolukhin/chrome_root/**src/native_client/toolchain/**
>> linux_x86_newlib/bin/x86_64-**nacl-gcc
>> -m32 -print-libgcc-file-name
>> chromeos-chrome-15.0.859.0_rc-**r1:
>> /home/dpolukhin/chrome_root/**src/native_client/toolchain/**
>> linux_x86_newlib/bin/x86_64-**nacl-gcc:
>> /lib32/libc.so.6: version `GLIBC_2.11' not found (required by
>> /home/dpolukhin/chrome_root/**src/native_client/toolchain/**
>> linux_x86_newlib/bin/x86_64-**nacl-gcc)
>> chromeos-chrome-15.0.859.0_rc-**r1: scons: *** Error 1
>>
>> ...
>>
>> chromeos-chrome-15.0.859.0_rc-**r1: Install file:
>> "src/untrusted/stubs/crt1.x" as
>> "scons-out/nacl_irt-x86-32/**obj/src/untrusted/stubs/crt1.**o"
>> chromeos-chrome-15.0.859.0_rc-**r1:
>> /home/dpolukhin/chrome_root/**src/native_client/toolchain/**
>> linux_x86_newlib/bin/x86_64-**nacl-ar
>> rc scons-out/nacl_irt-x86-32/obj/**src/untrusted/stubs/libcrt_**
>> platform.a
>> chromeos-chrome-15.0.859.0_rc-**r1:
>> /home/dpolukhin/chrome_root/**src/native_client/toolchain/**
>> linux_x86_newlib/bin/x86_64-**nacl-ar:
>> error while loading shared libraries: libz.so.1: cannot open shared object
>> file:
>> No such file or directory
>> chromeos-chrome-15.0.859.0_rc-**r1: Install file:
>> "src/shared/platform/nacl_log.**h"
>> as "scons-out/nacl_irt-x86-32/**include/nacl/nacl_log.h"
>> chromeos-chrome-15.0.859.0_rc-**r1: Install file:
>> "src/include/nacl/nacl_**inttypes.h" as
>> "scons-out/nacl_irt-x86-32/**include/nacl/nacl_inttypes.h"
>> chromeos-chrome-15.0.859.0_rc-**r1: scons: ***
>> [scons-out/nacl_irt-x86-32/**obj/src/untrusted/stubs/**libcrt_platform.a]
>> Error 127
>> chromeos-chrome-15.0.859.0_rc-**r1: scons: building terminated because of
>> errors.
>>
>>
>>
>>
http://codereview.chromium.**org/7701017/<http://codereview.chromium.org/7701...
>>
>
>