chrome/browser/extensions/file_manager_util.cc - Issue 7701015: Making BrowserNavigator open file browser singleton tab respecting URLs ref value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/file_manager_util.cc

Issue 7701015: Making BrowserNavigator open file browser singleton tab respecting URLs ref value (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: "Changing comments in browsertest" Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/file_manager_util.cc

diff --git a/chrome/browser/extensions/file_manager_util.cc b/chrome/browser/extensions/file_manager_util.cc

index f8310f9ad38267118589f15110c1944acc944908..706bf0455c219ac6bde49b15d57c351d5a8fe96c 100644

--- a/chrome/browser/extensions/file_manager_util.cc

+++ b/chrome/browser/extensions/file_manager_util.cc

@@ -210,10 +210,10 @@ void FileManagerUtil::ShowFullTabUrl(Profile*,

}

std::string url = chrome::kChromeUIFileManagerURL;

- url += '#' + EscapeUrlEncodedData(virtual_path.value(), false);

+ url += "#/" + EscapeUrlEncodedData(virtual_path.value(), false);

UserMetrics::RecordAction(UserMetricsAction("ShowFileBrowserFullTab"));

- browser->ShowSingletonTab(GURL(url));

+ browser->ShowSingletonTabRespectRef(GURL(url));

}

void FileManagerUtil::ViewItem(const FilePath& full_path, bool enqueue) {

« no previous file with comments | « no previous file | chrome/browser/ui/browser.h » ('j') | chrome/browser/ui/browser.cc » ('J')