chrome/browser/ui/browser.cc - Issue 7701015: Making BrowserNavigator open file browser singleton tab respecting URLs ref value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser.cc

Issue 7701015: Making BrowserNavigator open file browser singleton tab respecting URLs ref value (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: "Changing comments in browsertest" Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/browser.cc

diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc

index 72b6f33163898ed4e6ea749d8eaf4bfeef905642..7182b4fdd6b97c4635dcbacb0dac46a49af57b76 100644

--- a/chrome/browser/ui/browser.cc

+++ b/chrome/browser/ui/browser.cc

@@ -1255,6 +1255,12 @@ void Browser::ShowSingletonTab(const GURL& url) {

browser::Navigate(&params);

}

+void Browser::ShowSingletonTabRespectRef(const GURL& url) {

+ browser::NavigateParams params(GetSingletonTabNavigateParams(url));

+ params.ref_behavior = browser::NavigateParams::RESPECT_REF;

+ browser::Navigate(&params);

void Browser::ShowSingletonTabOverwritingNTP(

const browser::NavigateParams& params) {

browser::NavigateParams local_params(params);

@@ -2110,7 +2116,8 @@ void Browser::OpenSearchEngineOptionsDialog() {

#if defined(FILE_MANAGER_EXTENSION)

void Browser::OpenFileManager() {

UserMetrics::RecordAction(UserMetricsAction("OpenFileManager"));

- ShowSingletonTab(GURL(chrome::kChromeUIFileManagerURL));

+ ShowSingletonTabRespectRef(GURL(

+ std::string(chrome::kChromeUIFileManagerURL) + "#/"));

SeRya 2011/08/25 09:19:51 This change forces file manager to open up in the

}

#endif

« no previous file with comments | « chrome/browser/ui/browser.h ('k') | chrome/browser/ui/browser_navigator.h » ('j') | no next file with comments »