Making BrowserNavigator open file browser singleton tab respecting URLs ref value

Making BrowserNavigator open file browser singleton tab respecting URLs ref value

BUG=chromium-os:19260, chromium-os:15718
TEST= Manual on Cr48:
* Inserting, then removing and inserting removable device again. After both insertions, filebrowser tab pointing to device contents should be shown.
* Clicking ctrl+M with a file browser tab opened (the tab should not point to the root dir). New file browser tab pointing to the root dir should be opened.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98127

[Greg Billock, 2011-08-23 23:38:48]

So this will make different directories show up in different tabs? Is that the
desired behavior?

http://codereview.chromium.org/7701015/diff/1/chrome/browser/ui/browser_navig...
File chrome/browser/ui/browser_navigator.cc (right):

http://codereview.chromium.org/7701015/diff/1/chrome/browser/ui/browser_navig...
chrome/browser/ui/browser_navigator.cc:506: if (params->ref_behavior ==
browser::NavigateParams::IGNORE_REF)
Can you add a browser_navigator_browsertest for this?

http://codereview.chromium.org/7701015/diff/1/chrome/browser/ui/browser_navig...
File chrome/browser/ui/browser_navigator.h (right):

http://codereview.chromium.org/7701015/diff/1/chrome/browser/ui/browser_navig...
chrome/browser/ui/browser_navigator.h:160: RefBehavior ref_behavior;
Should this be called 'fragment'? I suppose in the NavigateParams usage it's
called 'ref' so...

[tbarzic, 2011-08-24 00:02:58]

This only affects cases when we open new file browser tab (opening new tab when
removable device gets inserted or clicking ctrl+M), not e.g. changing
directories inside that browser tab.

http://codereview.chromium.org/7701015/diff/1/chrome/browser/ui/browser_navig...
File chrome/browser/ui/browser_navigator.cc (right):

http://codereview.chromium.org/7701015/diff/1/chrome/browser/ui/browser_navig...
chrome/browser/ui/browser_navigator.cc:506: if (params->ref_behavior ==
browser::NavigateParams::IGNORE_REF)
On 2011/08/23 23:38:48, Greg Billock wrote:
> Can you add a browser_navigator_browsertest for this?

will do

http://codereview.chromium.org/7701015/diff/1/chrome/browser/ui/browser_navig...
File chrome/browser/ui/browser_navigator.h (right):

http://codereview.chromium.org/7701015/diff/1/chrome/browser/ui/browser_navig...
chrome/browser/ui/browser_navigator.h:160: RefBehavior ref_behavior;
On 2011/08/23 23:38:48, Greg Billock wrote:
> Should this be called 'fragment'? I suppose in the NavigateParams usage it's
> called 'ref' so...

hm.. fragment seem a bit better name, but I noticed that this code refers to it
as ref, so I guess it's better to leave it that way..

[Greg Billock, 2011-08-24 21:52:20]

LGTM

http://codereview.chromium.org/7701015/diff/6001/chrome/browser/ui/browser_na...
File chrome/browser/ui/browser_navigator_browsertest.cc (right):

http://codereview.chromium.org/7701015/diff/6001/chrome/browser/ui/browser_na...
chrome/browser/ui/browser_navigator_browsertest.cc:179: // Navigate to
singleton_url1.
singleton_ref_url2 (do you want url1 in line 182?)

[SeRya, 2011-08-25 09:19:51]

http://codereview.chromium.org/7701015/diff/12001/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

http://codereview.chromium.org/7701015/diff/12001/chrome/browser/ui/browser.c...
chrome/browser/ui/browser.cc:2120: std::string(chrome::kChromeUIFileManagerURL)
+ "#/"));
This change forces file manager to open up in the root directory. Default
behavior (triggered by empty hash) is navigating to to 'Downloads' folder if no
external storage attached.