Reland: Implement correct Panel closing sequence for Mac.

chrome/browser/ui/panels/panel.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/panel.h"
 
 #include "base/logging.h"
 #include "chrome/browser/extensions/extension_prefs.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 74 matching lines @@
 
 void Panel::SetBounds(const gfx::Rect& bounds) {
   // Ignore any SetBounds requests since the bounds are completely controlled
   // by panel manager.
 }
 
 // Close() may be called multiple times if the browser window is not ready to
 // close on the first attempt.
 void Panel::Close() {
   native_panel_->ClosePanel();
+
+// TODO(dimich): we need to only remove the panel when and if it actually
+// closes. It is now only implemented on Mac (unless it's synchronous on other

[jennb, 2011/08/22 19:13:02]

Change the 2nd sentence to state that changes are needed for other platforms.
Else it's not clear what the TODO action should be.

+// platforms).
+#if !defined(OS_MACOSX)
   manager()->Remove(this);
+#endif
 }
 
 void Panel::Activate() {
   native_panel_->ActivatePanel();
 }
 
 void Panel::Deactivate() {
   native_panel_->DeactivatePanel();
 }
 
@@ skipping 327 matching lines @@
 }
 #endif
 
 Browser* Panel::browser() const {
   return native_panel_->GetPanelBrowser();
 }
 
 void Panel::DestroyBrowser() {
   native_panel_->DestroyPanelBrowser();
 }