Issue 7693028: Switching NaCl IRT to be built inside the chrome build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7693028: Switching NaCl IRT to be built inside the chrome build. (Closed)

Created:
9 years, 4 months ago by bradn

Modified:
9 years, 4 months ago

Reviewers:
noelallen_use_chromium

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Switching NaCl IRT to be built inside the chrome build. Fifth attempt to land! Switching IRT to be built inside the chrome build. Dropping the IRT download step from the DEPS. Step3 of a many step plan to switch where ppapi + irt are built. Dropping download_nacl_irt because we no longer rely on a prebuilt copy. Dropping irt download drop source tarball (assume people using it will have to download / build their own nacl toolchain). Old Review URL: http://codereview.chromium.org/7669058 R=noelallen@google.com BUG=http://code.google.com/p/chromium/issues/detail?id=93520 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98106

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -255 lines)			Patch
M	DEPS	View	4 chunks	+9 lines, -22 lines	0 comments	Download
D	build/download_nacl_irt.py	View	1 chunk	+0 lines, -205 lines	0 comments	Download
A +	chrome/build_nacl_irt.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/nacl.gypi	View	2 chunks	+54 lines, -18 lines	0 comments	Download
M	tools/export_tarball/export_tarball.py	View	1 chunk	+0 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Submitting TBR (minor change from previous versions).

Expand Messages | Collapse Messages