Issue 7685006: Implement input type=color UI (common part)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+494 lines, -0 lines)			Patch
M	build/common.gypi	View	1 2 3 4 5	4 chunks	+13 lines, -0 lines	0 comments	Download
A	chrome/browser/color_select_helper.h	View	1 2 3 4	1 chunk	+84 lines, -0 lines	1 comment	Download
A	chrome/browser/color_select_helper.cc	View	1 2 3 4	1 chunk	+122 lines, -0 lines	1 comment	Download
A	chrome/browser/ui/color_chooser.h	View	1 2 3 4	1 chunk	+42 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/color_chooser.cc	View	1 2	1 chunk	+23 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/tab_contents/tab_contents_wrapper.h	View	1 2 3 4	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/tab_contents/tab_contents_wrapper.cc	View	1 2 3 4	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3 4	2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host.h	View	1 2 3 4	2 chunks	+10 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host.cc	View	1 2 3 4	1 chunk	+9 lines, -0 lines	0 comments	Download
M	content/common/view_messages.h	View	1 2 3 4	3 chunks	+25 lines, -0 lines	0 comments	Download
M	content/content_renderer.gypi	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/renderer/render_view_impl.h	View	1 2 3 4	4 chunks	+14 lines, -0 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View	1 2 3 4	5 chunks	+37 lines, -0 lines	0 comments	Download
A	content/renderer/renderer_webcolorchooser_impl.h	View	1 2 3 4	1 chunk	+40 lines, -0 lines	2 comments	Download
A	content/renderer/renderer_webcolorchooser_impl.cc	View	1 2 3 4	1 chunk	+57 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

yosin_UTC9

9 years ago (2011-12-06 07:11:17 UTC) #1

Small style related comments.

http://codereview.chromium.org/7685006/diff/21001/chrome/browser/color_select...
File chrome/browser/color_select_helper.cc (right):

http://codereview.chromium.org/7685006/diff/21001/chrome/browser/color_select...
chrome/browser/color_select_helper.cc:67: color_chooser_dialog_ = 0;
Please use NULL for pointers. 
This comment applies all others too.

According to:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#0_and_NULL

http://codereview.chromium.org/7685006/diff/21001/chrome/browser/color_select...
File chrome/browser/color_select_helper.h (right):

http://codereview.chromium.org/7685006/diff/21001/chrome/browser/color_select...
chrome/browser/color_select_helper.h:51: #endif
We want to have
DISALLOW_COPY_AND_ASSIGN(ColorSelectHelper);

http://codereview.chromium.org/7685006/diff/21001/content/renderer/renderer_w...
File content/renderer/renderer_webcolorchooser_impl.h (right):

http://codereview.chromium.org/7685006/diff/21001/content/renderer/renderer_w...
content/renderer/renderer_webcolorchooser_impl.h:23: virtual void
open(WebKit::WebColor);
Please insert OVERRIDE before semi-colon for override methods. This comment
applies rest of them.

http://codereview.chromium.org/7685006/diff/21001/content/renderer/renderer_w...
content/renderer/renderer_webcolorchooser_impl.h:36: };
Please add  DISALLOW_COPY_AND_ASSIGN(RendererWebColorChooserImpl)

Expand Messages | Collapse Messages