Switch to using .pak files for locale data on Windows.

Switch to using .pak files for locale data on Windows.

We were using .dlls, but the .pak files are smaller and this will
allow us to share more code across platforms.

- Remove app/locales.gyp (used on win to generate the locale dlls) and references to it in other gyp(i) files.
- Update various packaging scripts.
- Move functions from resource_bundle_posix.cc to resource_bundle.cc (LoadResourcesDataPak, UnloadLocaleResources, GetLocalizedString, LoadLocaleResources) and delete the corresponding functions from resource_bundle_win.cc.

BUG=92724
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97941

[tony, 2011-08-22 16:21:13]

rsesek: Can you review the ResourceBundle changes?
cpu or bradnelson: Can you review the mini_installer/FILES changes?

[Robert Sesek, 2011-08-22 16:56:32]

resource_bundle* on the whole LGTM, but I'm not qualified to review the
Windows-specific changes.

[tony, 2011-08-23 17:36:36]

Carlos, can you review this patch?  If not, let me know and I'll find someone
else.

[cpu_(ooo_6.6-7.5), 2011-08-23 21:48:25]

lgtm

I have this nagging feeling we forgot to do something for chrome frame but I
looked and looked and cannot find what.

http://codereview.chromium.org/7677004/diff/5001/ui/base/resource/resource_bu...
File ui/base/resource/resource_bundle.h (right):

http://codereview.chromium.org/7677004/diff/5001/ui/base/resource/resource_bu...
ui/base/resource/resource_bundle.h:87: // is responsible for cleaning up this
pointer.
cleaning = deleting?   sounds vague as is.

http://codereview.chromium.org/7677004/diff/5001/ui/base/resource/resource_bu...
File ui/base/resource/resource_bundle_win.cc (right):

http://codereview.chromium.org/7677004/diff/5001/ui/base/resource/resource_bu...
ui/base/resource/resource_bundle_win.cc:7: #include <atlbase.h>
so we don't need atlbase.h ?

[tony, 2011-08-23 22:30:51]

Thanks for the review!

http://codereview.chromium.org/7677004/diff/5001/ui/base/resource/resource_bu...
File ui/base/resource/resource_bundle.h (right):

http://codereview.chromium.org/7677004/diff/5001/ui/base/resource/resource_bu...
ui/base/resource/resource_bundle.h:87: // is responsible for cleaning up this
pointer.
On 2011/08/23 21:48:25, cpu wrote:
> cleaning = deleting?   sounds vague as is.

Switched to "deleting".

http://codereview.chromium.org/7677004/diff/5001/ui/base/resource/resource_bu...
File ui/base/resource/resource_bundle_win.cc (right):

http://codereview.chromium.org/7677004/diff/5001/ui/base/resource/resource_bu...
ui/base/resource/resource_bundle_win.cc:7: #include <atlbase.h>
On 2011/08/23 21:48:25, cpu wrote:
> so we don't need atlbase.h ?

Unfortunately, we still do (see the code at line 96).  It looks like we have
some IDS_ values that are compiled into chrome.dll so we need ATL to get those
back out.  My long term goal is to move all resources out of chrome.dll then we
can get rid of ATL completely.