Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 7677001: Some fixes to panel support on Windows: (Closed)

Created:
9 years, 4 months ago by jianli
Modified:
9 years, 4 months ago
Reviewers:
jennb
CC:
chromium-reviews, jennb, Dmitry Titov, jianli, prasadt, dcheng, Paweł Hajdan Jr.
Visibility:
Public.

Description

Some fixes to panel support on Windows: 1) Do not minimize the panel in title-only state regardless current mouse position when the panel is being dragged. 2) Do not hide controls when panel is minimized. 3) Do not use the bold font for focused panel. 4) Change bounds animation time to shorter value per discussion. BUG=none TEST=browser tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97321

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -37 lines) Patch
M chrome/browser/ui/panels/panel.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_frame_view.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_frame_view.cc View 8 chunks +18 lines, -23 lines 3 comments Download
M chrome/browser/ui/panels/panel_browser_view.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_view_browsertest.cc View 3 chunks +15 lines, -8 lines 1 comment Download
M chrome/browser/ui/panels/panel_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel_manager.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jianli
9 years, 4 months ago (2011-08-17 21:05:16 UTC) #1
jennb
9 years, 4 months ago (2011-08-17 23:01:35 UTC) #2
LGTM

http://codereview.chromium.org/7677001/diff/1/chrome/browser/ui/panels/panel_...
File chrome/browser/ui/panels/panel_browser_frame_view.cc (right):

http://codereview.chromium.org/7677001/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_browser_frame_view.cc:575: gfx::Font*
PanelBrowserFrameView::GetTitleFont(PaintState paint_state) const {
Should we change this method to not take paint_state as a param?

http://codereview.chromium.org/7677001/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_browser_frame_view.cc:615: // No need to paint
other stuffs if panel is minimized.
s/stuffs/stuff

http://codereview.chromium.org/7677001/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_browser_frame_view.cc:661: // No need to paint
other stuffs if panel is minimized.
Ditto.

http://codereview.chromium.org/7677001/diff/1/chrome/browser/ui/panels/panel_...
File chrome/browser/ui/panels/panel_browser_view_browsertest.cc (right):

http://codereview.chromium.org/7677001/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_browser_view_browsertest.cc:287: // regardless
the current mouse position when the panel is being dragged.
s/regardless the/regardless of the

Powered by Google App Engine
This is Rietveld 408576698