Some fixes to panel support on Windows:

chrome/browser/ui/panels/panel_browser_frame_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/panel_browser_frame_view.h"
 
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/themes/theme_service.h"
 #include "chrome/browser/ui/panels/panel.h"
@@ skipping 33 matching lines @@
 
 // The spacing in pixels between the icon and the border/text.
 const int kIconSpacing = 4;
 
 // The height and width in pixels of the icon.
 const int kIconSize = 16;
 
 // The spacing in pixels between buttons or the button and the adjacent control.
 const int kButtonSpacing = 6;
 
+// The panel can be minimized to 3-pixel lines.
+const int kMinimizedPanelHeight = 3;
+
 // Colors used in painting the titlebar for drawing attention.
 const SkColor kBackgroundColorForAttention = 0xfffa983a;
 const SkColor kTitleTextColorForAttention = SK_ColorWHITE;
 
 struct ButtonResources {
   SkBitmap* normal_image;
   SkBitmap* mask_image;
   SkBitmap* hover_image;
   SkBitmap* pushed_image;
 
@@ skipping 29 matching lines @@
     bottom = rb.GetBitmapNamed(bottom_id);
     bottom_left = rb.GetBitmapNamed(bottom_left_id);
     left = rb.GetBitmapNamed(left_id);
   }
 };
 
 ButtonResources settings_button_resources;
 ButtonResources close_button_resources;
 EdgeResources frame_edges;
 EdgeResources client_edges;
-gfx::Font* active_font = NULL;
-gfx::Font* inactive_font = NULL;
+gfx::Font* title_font = NULL;
 SkBitmap* background_bitmap_for_attention = NULL;
 
 void LoadImageResources() {
   settings_button_resources.SetResources(
       IDR_BALLOON_WRENCH, 0, IDR_BALLOON_WRENCH_H, IDR_BALLOON_WRENCH_P);
 
   close_button_resources.SetResources(
       IDR_TAB_CLOSE, IDR_TAB_CLOSE_MASK, IDR_TAB_CLOSE_H, IDR_TAB_CLOSE_P);
 
   frame_edges.SetResources(
       IDR_WINDOW_TOP_LEFT_CORNER, IDR_WINDOW_TOP_CENTER,
       IDR_WINDOW_TOP_RIGHT_CORNER, IDR_WINDOW_RIGHT_SIDE,
       IDR_WINDOW_BOTTOM_RIGHT_CORNER, IDR_WINDOW_BOTTOM_CENTER,
       IDR_WINDOW_BOTTOM_LEFT_CORNER, IDR_WINDOW_LEFT_SIDE);
 
   client_edges.SetResources(
       IDR_APP_TOP_LEFT, IDR_APP_TOP_CENTER,
       IDR_APP_TOP_RIGHT, IDR_CONTENT_RIGHT_SIDE,
       IDR_CONTENT_BOTTOM_RIGHT_CORNER, IDR_CONTENT_BOTTOM_CENTER,
       IDR_CONTENT_BOTTOM_LEFT_CORNER, IDR_CONTENT_LEFT_SIDE);
 }
 
 void EnsureResourcesInitialized() {
   static bool resources_initialized = false;
   if (resources_initialized)
     return;
   resources_initialized = true;
 
   ResourceBundle& rb = ResourceBundle::GetSharedInstance();
-  active_font = new gfx::Font(rb.GetFont(ResourceBundle::BoldFont));
-  inactive_font = new gfx::Font(rb.GetFont(ResourceBundle::BaseFont));
+  title_font = new gfx::Font(rb.GetFont(ResourceBundle::BaseFont));
 
   // Creates a bitmap of the specified color.
   background_bitmap_for_attention = new SkBitmap();
   background_bitmap_for_attention->setConfig(
       SkBitmap::kARGB_8888_Config, 16, 16);
   background_bitmap_for_attention->allocPixels();
   background_bitmap_for_attention->eraseColor(kBackgroundColorForAttention);
 
   LoadImageResources();
 }
@@ skipping 202 matching lines @@
 }
 
 gfx::Size PanelBrowserFrameView::GetMinimumSize() {
   // This makes the panel be able to shrink to very small, like 3-pixel lines.
   // Since the panel cannot be resized by the user, we do not need to enforce
   // the minimum size.
   return gfx::Size();
 }
 
 void PanelBrowserFrameView::Layout() {
-  // If the panel height is smaller than the title-bar height, as in minimized
-  // case, we hide all controls.
-  bool is_control_visible = height() >= kTitlebarHeight;
-  close_button_->SetVisible(is_control_visible);
-  settings_button_->SetVisible(
-      is_control_visible && is_settings_button_visible_);
-  title_icon_->SetVisible(is_control_visible);
-  title_label_->SetVisible(is_control_visible);
-
   // Layout the close button.
   gfx::Size close_button_size = close_button_->GetPreferredSize();
   close_button_->SetBounds(
       width() - kFrameBorderThickness - kButtonSpacing -
           close_button_size.width(),
       (NonClientTopBorderHeight() - close_button_size.height()) / 2,
       close_button_size.width(),
       close_button_size.height());
 
   // Layout the settings button.
@@ skipping 177 matching lines @@
 }
 
 int PanelBrowserFrameView::NonClientBorderThickness() const {
   return kFrameBorderThickness + kClientEdgeThickness;
 }
 
 int PanelBrowserFrameView::NonClientTopBorderHeight() const {
   return kFrameBorderThickness + kTitlebarHeight + kClientEdgeThickness;
 }
 
+int PanelBrowserFrameView::MinimizedPanelHeight() {
+  return kMinimizedPanelHeight;
+}
+
 SkColor PanelBrowserFrameView::GetTitleColor(PaintState paint_state) const {
   switch (paint_state) {
     case PAINT_AS_INACTIVE:
       return GetThemeProvider()->GetColor(
           ThemeService::COLOR_BACKGROUND_TAB_TEXT);
     case PAINT_AS_ACTIVE:
       return GetThemeProvider()->GetColor(ThemeService::COLOR_TAB_TEXT);
     case PAINT_FOR_ATTENTION:
       return kTitleTextColorForAttention;
     default:
       NOTREACHED();
       return SkColor();
   }
 }
 
 gfx::Font* PanelBrowserFrameView::GetTitleFont(PaintState paint_state) const {

[jennb, 2011/08/17 23:01:35]

Should we change this method to not take paint_state as a param?

-  switch (paint_state) {
-    case PAINT_AS_INACTIVE:
-    case PAINT_FOR_ATTENTION:
-      return inactive_font;
-    case PAINT_AS_ACTIVE:
-      return active_font;
-    default:
-      NOTREACHED();
-      return NULL;
-  }
+  return title_font;
 }
 
 SkBitmap* PanelBrowserFrameView::GetFrameTheme(PaintState paint_state) const {
   switch (paint_state) {
     case PAINT_AS_INACTIVE:
       return GetThemeProvider()->GetBitmapNamed(IDR_THEME_TAB_BACKGROUND);
     case PAINT_AS_ACTIVE:
       return GetThemeProvider()->GetBitmapNamed(IDR_THEME_TOOLBAR);
     case PAINT_FOR_ATTENTION:
       return background_bitmap_for_attention;
@@ skipping 18 matching lines @@
                                close_button_resources.normal_image,
                                close_button_resources.mask_image);
 }
 
 void PanelBrowserFrameView::PaintFrameBorder(gfx::Canvas* canvas) {
   SkBitmap* theme_frame = GetFrameTheme(paint_state_);
 
   // Draw the theme frame.
   canvas->TileImageInt(*theme_frame, 0, 0, width(), height());
 
+  // No need to paint other stuffs if panel is minimized.

[jennb, 2011/08/17 23:01:35]

s/stuffs/stuff

+  if (height() <= kMinimizedPanelHeight)
+    return;
+
   // Draw the top border.
   canvas->DrawBitmapInt(*(frame_edges.top_left), 0, 0);
   canvas->TileImageInt(
       *(frame_edges.top), frame_edges.top_left->width(), 0,
       width() - frame_edges.top_right->width(), frame_edges.top->height());
   canvas->DrawBitmapInt(
       *(frame_edges.top_right),
       width() - frame_edges.top_right->width(), 0);
 
   // Draw the right border.
@@ skipping 22 matching lines @@
   canvas->TileImageInt(
       *(frame_edges.left), 0, frame_edges.top_left->height(),
       frame_edges.left->width(),
       height() - frame_edges.top_left->height() -
           frame_edges.bottom_left->height());
 }
 
 void PanelBrowserFrameView::PaintClientEdge(gfx::Canvas* canvas) {
   int client_area_top = client_view_bounds_.y();
 
+  // No need to paint other stuffs if panel is minimized.

[jennb, 2011/08/17 23:01:35]

Ditto.

+  if (height() <= kMinimizedPanelHeight)
+    return;
+
   // Draw the top edge.
   int top_edge_y = client_area_top - client_edges.top->height();
   canvas->DrawBitmapInt(
       *(client_edges.top_left),
       client_view_bounds_.x() - client_edges.top_left->width(),
       top_edge_y);
   canvas->TileImageInt(
       *(client_edges.top), client_view_bounds_.x(), top_edge_y,
       client_view_bounds_.width(), client_edges.top->height());
   canvas->DrawBitmapInt(
@@ skipping 70 matching lines @@
   settings_menu_contents_.AddItem(
       COMMAND_DISABLE, l10n_util::GetStringUTF16(IDS_EXTENSIONS_DISABLE));
   settings_menu_contents_.AddItem(
       COMMAND_UNINSTALL, l10n_util::GetStringUTF16(IDS_EXTENSIONS_UNINSTALL));
   settings_menu_contents_.AddSeparator();
   settings_menu_contents_.AddItem(
       COMMAND_MANAGE, l10n_util::GetStringUTF16(IDS_MANAGE_EXTENSIONS));
 
   settings_menu_adapter_.BuildMenu(&settings_menu_);
 }