Revert 97056 - Gyp fix for release build.

Revert 97056 - Gyp fix for release build.

Reserve 1GB at the base of the address space of linux nacl_helper for Native Client module. Use PathService instead of command line flag to enable helper. Adds a nacl_helper_bootstrap executable that implements the actual space reservation.

See http://codereview.chromium.org/7599011 for extended revision history. This is a gyp fix following a revert.

TBR=agl,bradnelson

BUG=92964, nativeclient:480
TEST=manual for now

Review URL: http://codereview.chromium.org/7670011

TBR=bradchen@google.com
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97058

[Brad Chen, 2011-08-16 23:50:55]

LGTM

On Tue, Aug 16, 2011 at 4:44 PM, <rvargas@chromium.org> wrote:

> Reviewers: Brad Chen,
>
> Description:
> Revert 97056 - Gyp fix for release build.
>
> Reserve 1GB at the base of the address space of linux nacl_helper for
> Native
> Client module. Use PathService instead of command line flag to enable
> helper.
> Adds a nacl_helper_bootstrap executable that implements the actual space
> reservation.
>
> See
http://codereview.chromium.**org/7599011<http://codereview.chromium.org/75990...
extended revision history. This
> is a gyp fix following a revert.
>
> TBR=agl,bradnelson
>
> BUG=92964, nativeclient:480
> TEST=manual for now
>
> Review URL:
http://codereview.chromium.**org/7670011<http://codereview.chromium.org/7670011>
>
> TBR=bradchen@google.com
>
> Please review this at
http://codereview.chromium.**org/7671011/<http://codereview.chromium.org/7671...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>  M     chrome/common/chrome_paths.h
>  M     chrome/common/chrome_paths.cc
>  M     chrome/nacl.gypi
>  M     chrome/nacl/nacl_fork_**delegate_linux.cc
>  D     chrome/nacl/nacl_helper_**bootstrap_linux.c
>  D     chrome/nacl/nacl_helper_**exports.txt
>  M     chrome/nacl/nacl_helper_linux.**cc
>  M     tools/ld_bfd/ld
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.

[Brad Chen, 2011-08-16 23:50:59]

LGTM

On Tue, Aug 16, 2011 at 4:44 PM, <rvargas@chromium.org> wrote:

> Reviewers: Brad Chen,
>
> Description:
> Revert 97056 - Gyp fix for release build.
>
> Reserve 1GB at the base of the address space of linux nacl_helper for
> Native
> Client module. Use PathService instead of command line flag to enable
> helper.
> Adds a nacl_helper_bootstrap executable that implements the actual space
> reservation.
>
> See
http://codereview.chromium.**org/7599011<http://codereview.chromium.org/75990...
extended revision history. This
> is a gyp fix following a revert.
>
> TBR=agl,bradnelson
>
> BUG=92964, nativeclient:480
> TEST=manual for now
>
> Review URL:
http://codereview.chromium.**org/7670011<http://codereview.chromium.org/7670011>
>
> TBR=bradchen@google.com
>
> Please review this at
http://codereview.chromium.**org/7671011/<http://codereview.chromium.org/7671...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>  M     chrome/common/chrome_paths.h
>  M     chrome/common/chrome_paths.cc
>  M     chrome/nacl.gypi
>  M     chrome/nacl/nacl_fork_**delegate_linux.cc
>  D     chrome/nacl/nacl_helper_**bootstrap_linux.c
>  D     chrome/nacl/nacl_helper_**exports.txt
>  M     chrome/nacl/nacl_helper_linux.**cc
>  M     tools/ld_bfd/ld
>
>
>