Issue 7670011: Reserve 1GB at the base address of linux nacl_helper for Native Client.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7670011: Reserve 1GB at the base address of linux nacl_helper for Native Client. (Closed)

Created:
9 years, 4 months ago by Brad Chen

Modified:
9 years, 4 months ago

Reviewers:
bradnelson, agl

CC:
chromium-reviews, native-client-reviews_googlegroups.com, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Gyp fix for release build. Reserve 1GB at the base of the address space of linux nacl_helper for Native Client module. Use PathService instead of command line flag to enable helper. Adds a nacl_helper_bootstrap executable that implements the actual space reservation. See http://codereview.chromium.org/7599011 for extended revision history. This is a gyp fix following a revert. TBR=agl,bradnelson BUG=92964, nativeclient:480 TEST=manual for now Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97056

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+123 lines, -12 lines)			Patch
M	chrome/common/chrome_paths.h	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/common/chrome_paths.cc	View	2 chunks	+13 lines, -0 lines	0 comments	Download
M	chrome/nacl.gypi	View	2 chunks	+32 lines, -2 lines	0 comments	Download
M	chrome/nacl/nacl_fork_delegate_linux.cc	View	2 chunks	+15 lines, -7 lines	0 comments	Download
A	chrome/nacl/nacl_helper_bootstrap_linux.c	View	1 chunk	+24 lines, -0 lines	0 comments	Download
A	chrome/nacl/nacl_helper_exports.txt	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	chrome/nacl/nacl_helper_linux.cc	View	2 chunks	+22 lines, -2 lines	0 comments	Download
M	tools/ld_bfd/ld	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Brad Chen

This is a one-line fix nacl.gypi to reverted 7599011 as per Brad Nelson's suggestion on ...

9 years, 4 months ago (2011-08-16 23:03:16 UTC) #1

rubber stamp LGTM

Expand Messages | Collapse Messages