Issue 7669012: Broke BrowserAccessibilityTest.HitTestTest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7669012: Broke BrowserAccessibilityTest.HitTestTest (Closed)

Created:
9 years, 4 months ago by Chris Guillory

Modified:
9 years, 4 months ago

Reviewers:
Chris Guillory

CC:
chromium-reviews, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, jam, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, joi+watch-content_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, Paweł Hajdan Jr., ctguil+watch_chromium.org, zork+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Broke BrowserAccessibilityTest.HitTestTest Revert 97076 - Add DCHECK to BrowserAccessibilityManager::Remove to detect undefined behavoir that may lead to a crash. - Remove logic BrowserAccessibilityManagerTest.TestCreateEmptyDocument that attempts to change an accessibility object's role. BUG=92716 Test=none Review URL: http://codereview.chromium.org/7648055 TBR=ctguil@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97080

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	chrome/browser/accessibility/browser_accessibility_manager_unittest.cc	View		2 chunks	+7 lines, -4 lines	0 comments	Download
	MM	content/browser/accessibility/browser_accessibility_manager.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages