Issue 7648055: Add DCHECK to BrowserAccessibilityManager::Remove to detect undefined behavoir that may lead to a...

Issue 7648055: Add DCHECK to BrowserAccessibilityManager::Remove to detect undefined behavoir that may lead to a... (Closed)

Created:
9 years, 4 months ago by Chris Guillory

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, David Tseng

CC:
chromium-reviews, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, jam, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, joi+watch-content_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org, dmazzoni at google

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add DCHECK to BrowserAccessibilityManager::Remove to detect undefined behavoir that may lead to a crash. - Remove logic BrowserAccessibilityManagerTest.TestCreateEmptyDocument that attempts to change an accessibility object's role. - Update BrowserAccessibilityTest to have unique ids for all nodes. BUG=92716 Test=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97076 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97235

Patch Set 1 #

Patch Set 2 : Upload for try to work correctly.. #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Patch Set 5 : Address unit_tests errors on mac #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -7 lines)			Patch
M	chrome/browser/accessibility/browser_accessibility_mac_unittest.mm	View	1 2 3 4	2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/accessibility/browser_accessibility_manager_unittest.cc	View	1 2 3 4	2 chunks	+4 lines, -7 lines	0 comments	Download
M	content/browser/accessibility/browser_accessibility_manager.cc	View	1 2 3 4	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...

9 years, 4 months ago (2011-08-16 20:25:23 UTC) #3

Chris Guillory

Hey David, can you look over this update to BrowserAccessibilityManagerTest.TestCreateEmptyDocument. I think this will address ...

9 years, 4 months ago (2011-08-16 23:01:29 UTC) #4

David Tseng

http://codereview.chromium.org/7648055/diff/8001/chrome/browser/accessibility/browser_accessibility_manager_unittest.cc File chrome/browser/accessibility/browser_accessibility_manager_unittest.cc (left): http://codereview.chromium.org/7648055/diff/8001/chrome/browser/accessibility/browser_accessibility_manager_unittest.cc#oldcode626 chrome/browser/accessibility/browser_accessibility_manager_unittest.cc:626: // Verify we don't reuse objects that have changed ...

9 years, 4 months ago (2011-08-16 23:32:51 UTC) #5

Chris Guillory

9 years, 4 months ago (2011-08-17 00:00:42 UTC) #6

Change committed as 97235

Expand Messages | Collapse Messages