Issue 7661012: Add suppressions for download code after some recent refactorings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7661012: Add suppressions for download code after some recent refactorings. (Closed)

Created:
9 years, 4 months ago by jam

Modified:
9 years, 4 months ago

Reviewers:
Timur Iskhodzhanov

CC:
chromium-reviews, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add suppressions for download code after some recent refactorings. BUG=93006 TBR=timurrrr Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96901

Patch Set 1 #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+110 lines, -0 lines)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+110 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

LGTM but you've forgotten to add Heapchecker suppressions http://codereview.chromium.org/7661012/diff/1/tools/valgrind/memcheck/suppressions.txt File tools/valgrind/memcheck/suppressions.txt (right): http://codereview.chromium.org/7661012/diff/1/tools/valgrind/memcheck/suppressions.txt#newcode5303 tools/valgrind/memcheck/suppressions.txt:5303: fun:_ZN7testing8internal15TestFactoryImplI43DownloadManagerTest_DownloadCancelTest_TestE10CreateTestEv ...

9 years, 4 months ago (2011-08-16 08:09:48 UTC) #2

Timur Iskhodzhanov

9 years, 4 months ago (2011-08-16 08:25:14 UTC) #3

Also, you've missed a few tests.

Consider using ./tools/valgrind/waterfall.sh script to suppress numerous
reports, see
http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/mem...

Expand Messages | Collapse Messages