Add suppressions for download code after some recent refactorings.

tools/valgrind/memcheck/suppressions.txt

 # There are three kinds of suppressions in this file.
 # 1. third party stuff we have no control over
 #
 # 2. intentional unit test errors, or stuff that is somehow a false positive
 # in our own code, or stuff that is so trivial it's not worth fixing
 #
 # 3. Suppressions for real chromium bugs that are not yet fixed.
 # These should all be in chromium's bug tracking system (but a few aren't yet).
 # Periodically we should sweep this file and the bug tracker clean by
 # running overnight and removing outdated bugs/suppressions.
@@ skipping 5276 matching lines @@
    fun:_Znw*
    fun:_ZN3net18SSLClientSocketNSS10BufferSendEv
    fun:_ZN3net18SSLClientSocketNSS13DoTransportIOEv
    fun:_ZN3net18SSLClientSocketNSS15DoHandshakeLoopEi
    fun:_ZN3net18SSLClientSocketNSS7ConnectEP14CallbackRunnerI6Tuple1IiEE
    fun:_ZN3net13SSLConnectJob12DoSSLConnectEv
    fun:_ZN3net13SSLConnectJob6DoLoopEi
    fun:_ZN3net13SSLConnectJob12OnIOCompleteEi
    fun:_Z16DispatchToMethodIN3net13SSLConnectJobEMS1_FviEiEvPT_T0_RK6Tuple1IT1_E
 }
+{
+   bug_93006a
+   Memcheck:Leak
+   fun:_Znw*
+   fun:_ZN19DownloadManagerTestC2Ev
+   fun:_ZN43DownloadManagerTest_DownloadCancelTest_TestC1Ev
+   fun:_ZN7testing8internal15TestFactoryImplI43DownloadManagerTest_DownloadCancelTest_TestE10CreateTestEv

[Timur Iskhodzhanov, 2011/08/16 08:09:48]

the testing:: frames are not required.
I'll try to make a change to the suppression generator to drop these

+   fun:_ZN7testing8internal38HandleSehExceptionsInMethodIfSupportedINS0_15TestFactoryBaseEPNS_4TestEEET0_PT_MS6_FS5_vEPKc
+   fun:_ZN7testing8internal35HandleExceptionsInMethodIfSupportedINS0_15TestFactoryBaseEPNS_4TestEEET0_PT_MS6_FS5_vEPKc
+   fun:_ZN7testing8TestInfo3RunEv
+   fun:_ZN7testing8TestCase3RunEv
+   fun:_ZN7testing8internal12UnitTestImpl11RunAllTestsEv
+   fun:_ZN7testing8internal38HandleSehExceptionsInMethodIfSupportedINS0_12UnitTestImplEbEET0_PT_MS4_FS3_vEPKc
+   fun:_ZN7testing8internal35HandleExceptionsInMethodIfSupportedINS0_12UnitTestImplEbEET0_PT_MS4_FS3_vEPKc
+   fun:_ZN7testing8UnitTest3RunEv
+   fun:_ZN4base9TestSuite3RunEv
+   fun:main
+}
+{
+   bug_93006b
+   Memcheck:Leak
+   fun:_Znw*
+   fun:_ZN19DownloadManagerTestC2Ev
+   fun:_ZN43DownloadManagerTest_DownloadRemoveTest_TestC1Ev
+   fun:_ZN7testing8internal15TestFactoryImplI43DownloadManagerTest_DownloadRemoveTest_TestE10CreateTestEv
+   fun:_ZN7testing8internal38HandleSehExceptionsInMethodIfSupportedINS0_15TestFactoryBaseEPNS_4TestEEET0_PT_MS6_FS5_vEPKc
+   fun:_ZN7testing8internal35HandleExceptionsInMethodIfSupportedINS0_15TestFactoryBaseEPNS_4TestEEET0_PT_MS6_FS5_vEPKc
+   fun:_ZN7testing8TestInfo3RunEv
+   fun:_ZN7testing8TestCase3RunEv
+   fun:_ZN7testing8internal12UnitTestImpl11RunAllTestsEv
+   fun:_ZN7testing8internal38HandleSehExceptionsInMethodIfSupportedINS0_12UnitTestImplEbEET0_PT_MS4_FS3_vEPKc
+   fun:_ZN7testing8internal35HandleExceptionsInMethodIfSupportedINS0_12UnitTestImplEbEET0_PT_MS4_FS3_vEPKc
+   fun:_ZN7testing8UnitTest3RunEv
+   fun:_ZN4base9TestSuite3RunEv
+   fun:main
+}
+{
+   bug_93006c
+   Memcheck:Leak
+   fun:_Znw*
+   fun:_ZN19DownloadManagerTestC2Ev
+   fun:_ZN43DownloadManagerTest_DownloadRenameTest_TestC1Ev
+   fun:_ZN7testing8internal15TestFactoryImplI43DownloadManagerTest_DownloadRenameTest_TestE10CreateTestEv
+   fun:_ZN7testing8internal38HandleSehExceptionsInMethodIfSupportedINS0_15TestFactoryBaseEPNS_4TestEEET0_PT_MS6_FS5_vEPKc
+   fun:_ZN7testing8internal35HandleExceptionsInMethodIfSupportedINS0_15TestFactoryBaseEPNS_4TestEEET0_PT_MS6_FS5_vEPKc
+   fun:_ZN7testing8TestInfo3RunEv
+   fun:_ZN7testing8TestCase3RunEv
+   fun:_ZN7testing8internal12UnitTestImpl11RunAllTestsEv
+   fun:_ZN7testing8internal38HandleSehExceptionsInMethodIfSupportedINS0_12UnitTestImplEbEET0_PT_MS4_FS3_vEPKc
+   fun:_ZN7testing8internal35HandleExceptionsInMethodIfSupportedINS0_12UnitTestImplEbEET0_PT_MS4_FS3_vEPKc
+   fun:_ZN7testing8UnitTest3RunEv
+   fun:_ZN4base9TestSuite3RunEv
+   fun:main
+}
+{
+   bug_93006d
+   Memcheck:Leak
+   fun:_Znw*
+   fun:_ZN15DownloadManager4InitEP7Profile
+   fun:_ZN19DownloadManagerTestC2Ev
+   fun:_ZN38DownloadManagerTest_StartDownload_TestC1Ev
+   fun:_ZN7testing8internal15TestFactoryImplI38DownloadManagerTest_StartDownload_TestE10CreateTestEv
+   fun:_ZN7testing8internal38HandleSehExceptionsInMethodIfSupportedINS0_15TestFactoryBaseEPNS_4TestEEET0_PT_MS6_FS5_vEPKc
+   fun:_ZN7testing8internal35HandleExceptionsInMethodIfSupportedINS0_15TestFactoryBaseEPNS_4TestEEET0_PT_MS6_FS5_vEPKc
+   fun:_ZN7testing8TestInfo3RunEv
+   fun:_ZN7testing8TestCase3RunEv
+   fun:_ZN7testing8internal12UnitTestImpl11RunAllTestsEv
+   fun:_ZN7testing8internal38HandleSehExceptionsInMethodIfSupportedINS0_12UnitTestImplEbEET0_PT_MS4_FS3_vEPKc
+   fun:_ZN7testing8internal35HandleExceptionsInMethodIfSupportedINS0_12UnitTestImplEbEET0_PT_MS4_FS3_vEPKc
+   fun:_ZN7testing8UnitTest3RunEv
+   fun:_ZN4base9TestSuite3RunEv
+   fun:main
+}
+{
+   bug_93006e
+   Memcheck:Leak
+   fun:_Znw*
+   fun:_ZN19DownloadManagerTestC2Ev
+   fun:_ZN46DownloadManagerTest_DownloadOverwriteTest_TestC1Ev
+   fun:_ZN7testing8internal15TestFactoryImplI46DownloadManagerTest_DownloadOverwriteTest_TestE10CreateTestEv
+   fun:_ZN7testing8internal38HandleSehExceptionsInMethodIfSupportedINS0_15TestFactoryBaseEPNS_4TestEEET0_PT_MS6_FS5_vEPKc
+   fun:_ZN7testing8internal35HandleExceptionsInMethodIfSupportedINS0_15TestFactoryBaseEPNS_4TestEEET0_PT_MS6_FS5_vEPKc
+   fun:_ZN7testing8TestInfo3RunEv
+   fun:_ZN7testing8TestCase3RunEv
+   fun:_ZN7testing8internal12UnitTestImpl11RunAllTestsEv
+   fun:_ZN7testing8internal38HandleSehExceptionsInMethodIfSupportedINS0_12UnitTestImplEbEET0_PT_MS4_FS3_vEPKc
+   fun:_ZN7testing8internal35HandleExceptionsInMethodIfSupportedINS0_12UnitTestImplEbEET0_PT_MS4_FS3_vEPKc
+   fun:_ZN7testing8UnitTest3RunEv
+   fun:_ZN4base9TestSuite3RunEv
+   fun:main
+}
+{
+   bug_93006f
+   Memcheck:Leak
+   fun:_Znw*
+   fun:_ZN15DownloadManager4InitEP7Profile
+   fun:_ZN19DownloadManagerTestC2Ev
+   fun:_ZN46DownloadManagerTest_DownloadInterruptTest_TestC1Ev
+   fun:_ZN7testing8internal15TestFactoryImplI46DownloadManagerTest_DownloadInterruptTest_TestE10CreateTestEv
+   fun:_ZN7testing8internal38HandleSehExceptionsInMethodIfSupportedINS0_15TestFactoryBaseEPNS_4TestEEET0_PT_MS6_FS5_vEPKc
+   fun:_ZN7testing8internal35HandleExceptionsInMethodIfSupportedINS0_15TestFactoryBaseEPNS_4TestEEET0_PT_MS6_FS5_vEPKc
+   fun:_ZN7testing8TestInfo3RunEv
+   fun:_ZN7testing8TestCase3RunEv
+   fun:_ZN7testing8internal12UnitTestImpl11RunAllTestsEv
+   fun:_ZN7testing8internal38HandleSehExceptionsInMethodIfSupportedINS0_12UnitTestImplEbEET0_PT_MS4_FS3_vEPKc
+   fun:_ZN7testing8internal35HandleExceptionsInMethodIfSupportedINS0_12UnitTestImplEbEET0_PT_MS4_FS3_vEPKc
+   fun:_ZN7testing8UnitTest3RunEv
+   fun:_ZN4base9TestSuite3RunEv
+   fun:main
+}
 
 #-----------------------------------------------------------------------
 # These only occur on our Google workstations
 {
    bug_todo_freeres
    Memcheck:Free
    fun:free
    fun:__libc_freeres
    fun:_vgnU_freeres
    fun:_Exit
@@ skipping 10 matching lines @@
 }
 {
    bug_todo_getdelim2
    Memcheck:Leak
    fun:malloc
    fun:getdelim
    obj:/lib/libselinux.so.1
    obj:/lib/libselinux.so.1
    obj:/lib/libselinux.so.1
 }