Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 7660: Move windows specific lock-recursion-counter into windows impl file... (Closed)

Created:
12 years, 2 months ago by jar (doing other things)
Modified:
9 years, 7 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Move windows specific lock-recursion-counter into windows impl file Unix implementation of lock leaks the underlying lock_impl_ member so that the condition variable implementation can directly acquire and release the lock (without going through our abstract interface). This causse the recursion counter to become incorrect on such platforms. Windows uses an implementation of condition variables that uses our abstract interface, and hence is the only implementation that can track the recursion count (and besides... windows is the only platform that currently allows recursive (multiple) acquisitions of a lock by a single thread. I'll work on gracefully removing the depricated lock.cc after I've landed this change. r=cpu Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=3703

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -94 lines) Patch
M base/lock.h View 2 chunks +6 lines, -23 lines 0 comments Download
M base/lock.cc View 1 chunk +1 line, -69 lines 1 comment Download
M base/lock_impl.h View 1 chunk +7 lines, -0 lines 0 comments Download
M base/lock_impl_win.cc View 2 chunks +32 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jar (doing other things)
12 years, 2 months ago (2008-10-21 20:08:17 UTC) #1
cpu_(ooo_6.6-7.5)
12 years, 2 months ago (2008-10-21 22:41:23 UTC) #2
LGTM

http://codereview.chromium.org/7660/diff/1/2
File base/lock.cc (right):

http://codereview.chromium.org/7660/diff/1/2#newcode7
Line 7: // Depricated file.  See lock_impl_*.cc for platform specific versions.
Deprecated?

Powered by Google App Engine
This is Rietveld 408576698