Issue 7659009: Apply VPD customization even if startup customization manifest is missing.

Issue 7659009: Apply VPD customization even if startup customization manifest is missing. (Closed)

Created:
9 years, 4 months ago by Dmitry Polukhin

Modified:
9 years, 4 months ago

Reviewers:
whywhat

CC:
chromium-reviews, rharrison, davemoore+watch_chromium.org, nkostylev+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Apply VPD customization even if startup customization manifest is missing. BUG=chrome-os-partner:5116 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96914

Patch Set 2 : comments resolved #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -94 lines)			Patch
M	chrome/browser/chromeos/customization_document.h	View	1	1 chunk	+10 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/customization_document.cc	View		1 chunk	+34 lines, -34 lines	0 comments	Download
M	chrome/browser/chromeos/login/base_login_display_host.cc	View	1	3 chunks	+49 lines, -53 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

whywhat

LGTM http://codereview.chromium.org/7659009/diff/1/chrome/browser/chromeos/customization_document.h File chrome/browser/chromeos/customization_document.h (right): http://codereview.chromium.org/7659009/diff/1/chrome/browser/chromeos/customization_document.h#newcode72 chrome/browser/chromeos/customization_document.h:72: // These methods can be called even if ...

9 years, 4 months ago (2011-08-16 08:01:23 UTC) #2

Dmitry Polukhin

9 years, 4 months ago (2011-08-16 08:29:51 UTC) #3

http://codereview.chromium.org/7659009/diff/1/chrome/browser/chromeos/customi...
File chrome/browser/chromeos/customization_document.h (right):

http://codereview.chromium.org/7659009/diff/1/chrome/browser/chromeos/customi...
chrome/browser/chromeos/customization_document.h:72: // These methods can be
called even if !IsReady() in this case VPD values
On 2011/08/16 08:01:24, whywhat wrote:
> nit: comma or period after IsReady()

Done.

http://codereview.chromium.org/7659009/diff/1/chrome/browser/chromeos/customi...
chrome/browser/chromeos/customization_document.h:79:
FRIEND_TEST(StartupCustomizationDocumentTest, Basic);
On 2011/08/16 08:01:24, whywhat wrote:
> Could you replace with FRIEND_TEST_ALL_PREFIXES?

Done.

http://codereview.chromium.org/7659009/diff/1/chrome/browser/chromeos/login/b...
File chrome/browser/chromeos/login/base_login_display_host.cc (right):

http://codereview.chromium.org/7659009/diff/1/chrome/browser/chromeos/login/b...
chrome/browser/chromeos/login/base_login_display_host.cc:217: VLOG(1) <<
"Showing wizard screen: " << first_screen_name;
On 2011/08/16 08:01:24, whywhat wrote:
> nit: wizard -> OOBE?

Done.

http://codereview.chromium.org/7659009/diff/1/chrome/browser/chromeos/login/b...
chrome/browser/chromeos/login/base_login_display_host.cc:336: // Apply locale
customizations only once so preserve whatever locale
On 2011/08/16 08:01:24, whywhat wrote:
> nit: so -> to

Done.

Expand Messages | Collapse Messages