Apply VPD customization even if startup customization manifest is missing.

chrome/browser/chromeos/login/base_login_display_host.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/base_login_display_host.h"
 
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/threading/thread_restrictions.h"
@@ skipping 196 matching lines @@
 }  // namespace chromeos
 
 // browser::ShowLoginWizard implementation -------------------------------------
 
 namespace browser {
 
 // Declared in browser_dialogs.h so that others don't need to depend on our .h.
 // TODO(nkostylev): Split this into a smaller functions.
 void ShowLoginWizard(const std::string& first_screen_name,
                      const gfx::Size& size) {
-  VLOG(1) << "Showing login screen: " << first_screen_name;
+  VLOG(1) << "Showing wizard screen: " << first_screen_name;

[whywhat, 2011/08/16 08:01:24]

nit: wizard -> OOBE?

[Dmitry Polukhin, 2011/08/16 08:29:51]

Done.

 
   // The login screen will enable alternate keyboard layouts, but we don't want
   // to start the IME process unless one is selected.
   chromeos::input_method::InputMethodManager::GetInstance()->
       SetDeferImeStartup(true);
   // Tell the window manager that the user isn't logged in.
   chromeos::WmIpc::instance()->SetLoggedInProperty(false);
 
   // Set up keyboards. For example, when |locale| is "en-US", enable US qwerty
   // and US dvorak keyboard layouts.
@@ skipping 47 matching lines @@
       g_browser_process->SetApplicationLocale(loaded_locale);
     }
     display_host->StartSignInScreen();
     return;
   }
 
   // Load startup manifest.
   const chromeos::StartupCustomizationDocument* startup_manifest =
       chromeos::StartupCustomizationDocument::GetInstance();
 
+  // Switch to initial locale if specified by customization
+  // and has not been set yet. We cannot call
+  // chromeos::LanguageSwitchMenu::SwitchLanguage here before
+  // EmitLoginPromptReady.
+  PrefService* prefs = g_browser_process->local_state();
+  const std::string current_locale =
+      prefs->GetString(prefs::kApplicationLocale);
+  VLOG(1) << "Current locale: " << current_locale;
   std::string locale;
-  if (startup_manifest->IsReady()) {
-    // Switch to initial locale if specified by customization
-    // and has not been set yet. We cannot call
-    // chromeos::LanguageSwitchMenu::SwitchLanguage here before
-    // EmitLoginPromptReady.
-    PrefService* prefs = g_browser_process->local_state();
-    const std::string current_locale =
-        prefs->GetString(prefs::kApplicationLocale);
-    VLOG(1) << "Current locale: " << current_locale;
-    if (current_locale.empty()) {
-      locale = startup_manifest->initial_locale();
-      std::string layout = startup_manifest->keyboard_layout();
-      VLOG(1) << "Initial locale: " << locale
-              << "keyboard layout " << layout;
-      if (!locale.empty()) {
-        // Save initial locale from VPD/customization manifest as current
-        // Chrome locale. Otherwise it will be lost if Chrome restarts.
-        // Don't need to schedule pref save because setting initial local
-        // will enforce preference saving.
-        prefs->SetString(prefs::kApplicationLocale, locale);
-        chromeos::WizardController::SetInitialLocale(locale);
-        // Determine keyboard layout from OEM customization (if provided) or
-        // initial locale and save it in preferences.
-        DetermineAndSaveHardwareKeyboard(locale, layout);
-        // Then, enable the hardware keyboard.
-        chromeos::input_method::EnableInputMethods(
-            locale,
-            chromeos::input_method::kKeyboardLayoutsOnly,
-            chromeos::input_method::GetHardwareInputMethodId());
-        // Reloading resource bundle causes us to do blocking IO on UI thread.
-        // Temporarily allow it until we fix http://crosbug.com/11102
-        base::ThreadRestrictions::ScopedAllowIO allow_io;
-        const std::string loaded_locale =
-            ResourceBundle::ReloadSharedInstance(locale);
-        CHECK(!loaded_locale.empty()) << "Locale could not be found for "
-                                      << locale;
-        // Set the application locale here so that the language switch
-        // menu works properly with the newly loaded locale.
-        g_browser_process->SetApplicationLocale(loaded_locale);
-      }
+  if (current_locale.empty()) {
+    locale = startup_manifest->initial_locale();
+    std::string layout = startup_manifest->keyboard_layout();
+    VLOG(1) << "Initial locale: " << locale
+            << "keyboard layout " << layout;
+    if (!locale.empty()) {
+      // Save initial locale from VPD/customization manifest as current
+      // Chrome locale. Otherwise it will be lost if Chrome restarts.
+      // Don't need to schedule pref save because setting initial local
+      // will enforce preference saving.
+      prefs->SetString(prefs::kApplicationLocale, locale);
+      chromeos::WizardController::SetInitialLocale(locale);
+      // Determine keyboard layout from OEM customization (if provided) or
+      // initial locale and save it in preferences.
+      DetermineAndSaveHardwareKeyboard(locale, layout);
+      // Then, enable the hardware keyboard.
+      chromeos::input_method::EnableInputMethods(
+          locale,
+          chromeos::input_method::kKeyboardLayoutsOnly,
+          chromeos::input_method::GetHardwareInputMethodId());
+      // Reloading resource bundle causes us to do blocking IO on UI thread.
+      // Temporarily allow it until we fix http://crosbug.com/11102
+      base::ThreadRestrictions::ScopedAllowIO allow_io;
+      const std::string loaded_locale =
+          ResourceBundle::ReloadSharedInstance(locale);
+      CHECK(!loaded_locale.empty()) << "Locale could not be found for "
+                                    << locale;
+      // Set the application locale here so that the language switch
+      // menu works properly with the newly loaded locale.
+      g_browser_process->SetApplicationLocale(loaded_locale);
     }
   }
 
   display_host->StartWizard(first_screen_name, GURL());
 
   chromeos::LoginUtils::Get()->PrewarmAuthentication();
   if (chromeos::CrosLibrary::Get()->EnsureLoaded())
     chromeos::CrosLibrary::Get()->GetLoginLibrary()->EmitLoginPromptReady();
 
-  if (startup_manifest->IsReady()) {
-    // Set initial timezone if specified by customization.
-    const std::string timezone_name = startup_manifest->initial_timezone();
-    VLOG(1) << "Initial time zone: " << timezone_name;
-    // Apply locale customizations only once so preserve whatever locale
-    // user has changed to during OOBE.
-    if (!timezone_name.empty()) {
-      icu::TimeZone* timezone = icu::TimeZone::createTimeZone(
-          icu::UnicodeString::fromUTF8(timezone_name));
-      CHECK(timezone) << "Timezone could not be set for " << timezone_name;
-      chromeos::system::TimezoneSettings::GetInstance()->SetTimezone(*timezone);
-    }
+  // Set initial timezone if specified by customization.
+  const std::string timezone_name = startup_manifest->initial_timezone();
+  VLOG(1) << "Initial time zone: " << timezone_name;
+  // Apply locale customizations only once so preserve whatever locale

[whywhat, 2011/08/16 08:01:24]

nit: so -> to

[Dmitry Polukhin, 2011/08/16 08:29:51]

Done.

+  // user has changed to during OOBE.
+  if (!timezone_name.empty()) {
+    icu::TimeZone* timezone = icu::TimeZone::createTimeZone(
+        icu::UnicodeString::fromUTF8(timezone_name));
+    CHECK(timezone) << "Timezone could not be set for " << timezone_name;
+    chromeos::system::TimezoneSettings::GetInstance()->SetTimezone(*timezone);
   }
 }
 
 }  // namespace browser