Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 7655030: Unify GetElement handlers in ElementsAccessor (Closed)

Created:
9 years, 4 months ago by danno
Modified:
9 years, 4 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Unify GetElement handlers in ElementsAccessor BUG=none TEST=external-arrays.js Committed: http://code.google.com/p/v8/source/detail?r=8966

Patch Set 1 #

Patch Set 2 : fix nits #

Patch Set 3 : merge with latest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -121 lines) Patch
M src/elements.h View 2 chunks +11 lines, -10 lines 0 comments Download
M src/elements.cc View 1 13 chunks +79 lines, -103 lines 0 comments Download
M src/objects.cc View 1 2 4 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
danno
please take a look
9 years, 4 months ago (2011-08-17 21:24:28 UTC) #1
Sven Panne
9 years, 4 months ago (2011-08-18 08:53:46 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698