Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: src/elements.h

Issue 7655030: Unify GetElement handlers in ElementsAccessor (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: merge with latest Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/elements.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/elements.h
diff --git a/src/elements.h b/src/elements.h
index 9a4afcddc197de28bf2d0a24757ce79c0f5e5dbb..3eae303ed136b9a0879379e4a79393b32a545c55 100644
--- a/src/elements.h
+++ b/src/elements.h
@@ -39,16 +39,19 @@ class ElementsAccessor {
public:
ElementsAccessor() { }
virtual ~ElementsAccessor() { }
- virtual MaybeObject* GetWithReceiver(JSObject* obj,
- Object* receiver,
- uint32_t key) = 0;
+ virtual MaybeObject* Get(FixedArrayBase* backing_store,
+ uint32_t key,
+ JSObject* holder,
+ Object* receiver) = 0;
- virtual MaybeObject* Delete(JSObject* obj,
+ virtual MaybeObject* Delete(JSObject* holder,
uint32_t key,
JSReceiver::DeleteMode mode) = 0;
virtual MaybeObject* AddElementsToFixedArray(FixedArrayBase* from,
- FixedArray* to) = 0;
+ FixedArray* to,
+ JSObject* holder,
+ Object* receiver) = 0;
// Returns a shared ElementsAccessor for the specified ElementsKind.
static ElementsAccessor* ForKind(JSObject::ElementsKind elements_kind) {
@@ -63,14 +66,12 @@ class ElementsAccessor {
protected:
friend class NonStrictArgumentsElementsAccessor;
- // TODO(danno): GetElement should be merged with GetWithReceiver.
- virtual MaybeObject* GetElement(FixedArrayBase* backing_store,
- uint32_t key) = 0;
-
virtual uint32_t GetCapacity(FixedArrayBase* backing_store) = 0;
virtual bool HasElementAtIndex(FixedArrayBase* backing_store,
- uint32_t index) = 0;
+ uint32_t index,
+ JSObject* holder,
+ Object* receiver) = 0;
// Element handlers distinguish between indexes and keys when the manipulate
// elements. Indexes refer to elements in terms of their location in the
« no previous file with comments | « no previous file | src/elements.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698