Issue 7651002: Adding checks to guard against buffer overruns in QuotaFileIO::Write and base::FileUtilProxy::Write

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7651002: Adding checks to guard against buffer overruns in QuotaFileIO::Write and base::FileUtilProxy::Write (Closed)

Created:
9 years, 4 months ago by sanga

Modified:
9 years, 4 months ago

Reviewers:
nfullagar, noelallen_use_chromium, brettw

CC:
chromium-reviews, piman+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Adding checks to guard against buffer overruns in QuotaFileIO::Write and base::FileUtilProxy::Write Also made some minor changes to fix lint warnings. There are no tests for base::FileUtilProxy. BUG= http://code.google.com/p/nativeclient/issues/detail?id=2076 TEST= test_shell_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97147

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -3 lines)			Patch
M	base/file_util_proxy.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	base/file_util_proxy.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ppapi/c/ppb_file_io.h	View	3 chunks	+4 lines, -3 lines	1 comment	Download
M	webkit/plugins/ppapi/quota_file_io.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/quota_file_io.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/quota_file_io_unittest.cc	View	2 chunks	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

noelallen_use_chromium

This change modified a comment in the *.h directly instead of modifying the *.idl and ...

9 years, 4 months ago (2011-08-17 18:55:26 UTC) #4

noelallen_use_chromium

9 years, 4 months ago (2011-08-17 18:56:10 UTC) #5

http://codereview.chromium.org/7651002/diff/9001/ppapi/c/ppb_file_io.h
File ppapi/c/ppb_file_io.h (right):

http://codereview.chromium.org/7651002/diff/9001/ppapi/c/ppb_file_io.h#newcod...
ppapi/c/ppb_file_io.h:195: * PP_ERROR_FAILED.
These changes will be lost on the next generation.

Expand Messages | Collapse Messages