Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2674)

Unified Diff: base/file_util_proxy.h

Issue 7651002: Adding checks to guard against buffer overruns in QuotaFileIO::Write and base::FileUtilProxy::Write (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/file_util_proxy.cc » ('j') | ppapi/c/ppb_file_io.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/file_util_proxy.h
===================================================================
--- base/file_util_proxy.h (revision 96790)
+++ base/file_util_proxy.h (working copy)
@@ -168,6 +168,7 @@
// Writes to a file. If |offset| is greater than the length of the file,
// |false| is returned. On success, the file pointer is moved to position
// |offset + bytes_to_write| in the file. The callback can be NULL.
+ // |bytes_to_write| must be greater than zero.
static bool Write(
scoped_refptr<MessageLoopProxy> message_loop_proxy,
PlatformFile file,
« no previous file with comments | « no previous file | base/file_util_proxy.cc » ('j') | ppapi/c/ppb_file_io.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698