Issue 7650022: Skip updating rank in OnExternalCacheHit if cache is uninitialized or disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7650022: Skip updating rank in OnExternalCacheHit if cache is uninitialized or disabled. (Closed)

Created:
9 years, 4 months ago by James Simonsen

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, rvargas (doing something else)

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Skip updating rank in OnExternalCacheHit if cache is uninitialized or disabled. BUG=92913 TEST=net_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96882

Patch Set 2 : Only check disabled #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	net/disk_cache/backend_impl.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rvargas (doing something else)

Ooops. LGTM. http://codereview.chromium.org/7650022/diff/1/net/disk_cache/backend_impl.cc File net/disk_cache/backend_impl.cc (right): http://codereview.chromium.org/7650022/diff/1/net/disk_cache/backend_impl.cc#newcode686 net/disk_cache/backend_impl.cc:686: if (disabled_ || !data_) nit: disabled_ should ...

9 years, 4 months ago (2011-08-15 20:45:39 UTC) #2

Change committed as 96882

Expand Messages | Collapse Messages

Issue 7650022: Skip updating rank in OnExternalCacheHit if cache is uninitialized or disabled. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Only check disabled #

Messages