Skip updating rank in OnExternalCacheHit if cache is uninitialized or disabled.

net/disk_cache/backend_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/disk_cache/backend_impl.h"
 
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/message_loop.h"
 #include "base/metrics/field_trial.h"
@@ skipping 665 matching lines @@
   *prev_entry = OpenPrevEntryImpl(iter);
   return (*prev_entry) ? net::OK : net::ERR_FAILED;
 }
 
 void BackendImpl::SyncEndEnumeration(void* iter) {
   scoped_ptr<Rankings::Iterator> iterator(
       reinterpret_cast<Rankings::Iterator*>(iter));
 }
 
 void BackendImpl::SyncOnExternalCacheHit(const std::string& key) {
+  if (disabled_ || !data_)

[rvargas (doing something else), 2011/08/15 20:45:39]

nit: disabled_ should be enough (to be consistent with the checks on the rest of
the code).

+    return;
+
   uint32 hash = Hash(key);
   bool error;
   EntryImpl* cache_entry = MatchEntry(key, hash, false, Addr(), &error);
   if (cache_entry) {
     if (ENTRY_NORMAL == cache_entry->entry()->Data()->state) {
       UpdateRank(cache_entry, false);
     }
     cache_entry->Release();
   }
 }
@@ skipping 1416 matching lines @@
     if (total_memory > kMaxBuffersSize || total_memory <= 0)
       total_memory = kMaxBuffersSize;
 
     done = true;
   }
 
   return static_cast<int>(total_memory);
 }
 
 }  // namespace disk_cache