Issue 7650003: Fix up confirmation window not reshowing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7650003: Fix up confirmation window not reshowing. (Closed)

Created:
9 years, 4 months ago by dmac

Modified:
9 years, 4 months ago

Reviewers:
Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix up confirmation window not reshowing. BUG=92498 TEST=With remoting, Connect and keep the session there for > 10m, hit continue and do it again. Expect dialog to come up again. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96652

Patch Set 1 #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	remoting/host/desktop_environment.cc	View		2 chunks	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jamie

9 years, 4 months ago (2011-08-12 23:11:30 UTC) #2

LGTM

http://codereview.chromium.org/7650003/diff/1/remoting/host/desktop_environme...
File remoting/host/desktop_environment.cc (right):

http://codereview.chromium.org/7650003/diff/1/remoting/host/desktop_environme...
remoting/host/desktop_environment.cc:211: continue_timer_started_ = false;
D'oh!

Expand Messages | Collapse Messages