Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 7649021: Separate the (partial) decoder of the x86_32 validator into a separate library. (Closed)

Created:
9 years, 4 months ago by Karl
Modified:
9 years, 4 months ago
Reviewers:
Brad Chen
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Separate the (partial) decoder of the x86_32 validator into a separate library. Fix library ncval_seg_sfi_verbose to ncdis_seg_sfi_verbose, to show that verbose routines are only for ncdis. BUG= http://code.google.com/p/nativeclient/issues/detail?id=1899 Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=6437

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -17 lines) Patch
M site_scons/site_tools/library_deps.py View 4 chunks +11 lines, -9 lines 0 comments Download
M src/trusted/validator/x86/ncval_seg_sfi/build.scons View 1 chunk +6 lines, -3 lines 0 comments Download
M src/trusted/validator/x86/ncval_seg_sfi/ncdecode.c View 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/validator_x86/build.scons View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Karl
Please review. Thanks!
9 years, 4 months ago (2011-08-15 19:22:42 UTC) #1
Brad Chen
9 years, 4 months ago (2011-08-15 20:00:54 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698