Separate the (partial) decoder of the x86_32 validator into a separate library.

src/trusted/validator/x86/ncval_seg_sfi/ncdecode.c

 /*
  * Copyright (c) 2011 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /*
  * ncdecode.c - table driven decoder for Native Client
  *
  * Most x86 decoders I've looked at are big case statements. While
@@ skipping 31 matching lines @@
 
 /* To turn on debugging of instruction decoding, change value of
  * DEBUGGING to 1.
  */
 #define DEBUGGING 0
 
 #include "native_client/src/shared/utils/debugging.h"
 
 /* Generates a print name for the given NCDecodeImmediateType. */
 static const char* NCDecodeImmediateTypeName(NCDecodeImmediateType type) {
-  DEBUG(
+  DEBUG_OR_ERASE(
       switch(type) {
         case IMM_UNKNOWN: return "IMM_UNKNOWN";
         case IMM_NONE: return "IMM_NONE";
         case IMM_FIXED1: return "IMM_FIXED1";
         case IMM_FIXED2: return "IMM_FIXED2";
         case IMM_FIXED3: return "IMM_FIXED3";
         case IMM_FIXED4: return "IMM_FIXED4";
         case IMM_DATAV: return "IMM_DATAV";
         case IMM_ADDRV: return "IMM_ADDRV";
         case IMM_GROUP3_F6: return "IMM_GROUP3_F6";
@@ skipping 674 matching lines @@
     if (! (tthis->action_fn)(tthis, old_dinst, new_dinst)) {
       return FALSE;
     }
 
     /* Move to next instruction. */
     old_dinst = IncrementInst(old_dinst);
     new_dinst = IncrementInst(new_dinst);
   }
   return TRUE;
 }