Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: chrome/browser/metrics/metrics_service.cc

Issue 7649006: more changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix another typo Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/metrics_service.cc
diff --git a/chrome/browser/metrics/metrics_service.cc b/chrome/browser/metrics/metrics_service.cc
index aec969f705dd4a981095f2be367b9d953bca4739..333b8c82c306461a0234e3610e14823b0ce1c38e 100644
--- a/chrome/browser/metrics/metrics_service.cc
+++ b/chrome/browser/metrics/metrics_service.cc
@@ -1186,14 +1186,15 @@ void MetricsService::StoreUnsentLogsHelper(
return;
// Store size at the beginning of the list.
- list->Append(Value::CreateIntegerValue(local_list.size() - start));
+ list->Append(base::NumberValue::New(
+ static_cast<int>(local_list.size() - start)));
base::MD5Context ctx;
base::MD5Init(&ctx);
std::string encoded_log;
for (std::vector<std::string>::const_iterator it = local_list.begin() + start;
it != local_list.end(); ++it) {
- // We encode the compressed log as Value::CreateStringValue() expects to
+ // We encode the compressed log as base::StringValue::New() expects to
// take a valid UTF8 string.
if (!base::Base64Encode(*it, &encoded_log)) {
MakeStoreStatusHistogram(ENCODE_FAIL);
@@ -1201,13 +1202,13 @@ void MetricsService::StoreUnsentLogsHelper(
return;
}
base::MD5Update(&ctx, encoded_log);
- list->Append(Value::CreateStringValue(encoded_log));
+ list->Append(base::StringValue::New(encoded_log));
}
// Append hash to the end of the list.
base::MD5Digest digest;
base::MD5Final(&digest, &ctx);
- list->Append(Value::CreateStringValue(base::MD5DigestToBase16(digest)));
+ list->Append(base::StringValue::New(base::MD5DigestToBase16(digest)));
DCHECK(list->GetSize() >= 3); // Minimum of 3 elements (size, data, hash).
MakeStoreStatusHistogram(STORE_SUCCESS);
}
« no previous file with comments | « chrome/browser/media/media_internals_unittest.cc ('k') | chrome/browser/metrics/metrics_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698