Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: remoting/client/plugin/chromoting_scriptable_object.cc

Issue 7648042: Change Chromoting logger to be setup in plugin's NP_Initialize. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove comment Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/plugin/chromoting_scriptable_object.cc
diff --git a/remoting/client/plugin/chromoting_scriptable_object.cc b/remoting/client/plugin/chromoting_scriptable_object.cc
index 28c630397145cd0433c2adfeedb56044397ae988..86bfc498780fcbe6a7f8134d119f0638cdb48ebe 100644
--- a/remoting/client/plugin/chromoting_scriptable_object.cc
+++ b/remoting/client/plugin/chromoting_scriptable_object.cc
@@ -253,8 +253,10 @@ void ChromotingScriptableObject::LogDebugInfo(const std::string& info) {
cb.Call(Var(), Var(info), &exception);
if (!exception.is_undefined()) {
- LOG(WARNING) << "Exception when invoking debugInfo JS callback: "
- << exception.DebugString();
+ // Note that we cannot use LOG here because we're currently in the middle
+ // of handling a LOG message.
Wez 2011/08/30 05:20:02 We've got a check that prevents recursive calling
garykac 2011/08/31 00:59:00 The previous checks didn't work because they were
+ printf("Exception when invoking debugInfo JS callback: %s\n",
+ exception.DebugString());
}
}

Powered by Google App Engine
This is Rietveld 408576698