Change Chromoting logger to be setup in plugin's NP_Initialize.

remoting/client/plugin/chromoting_scriptable_object.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/client/plugin/chromoting_scriptable_object.h"
 
 #include "base/logging.h"
 #include "base/message_loop_proxy.h"
 // TODO(wez): Remove this when crbug.com/86353 is complete.
 #include "ppapi/cpp/private/var_private.h"
@@ skipping 235 matching lines @@
 
 void ChromotingScriptableObject::LogDebugInfo(const std::string& info) {
   Var exception;
   VarPrivate cb = GetProperty(Var(kDebugInfo), &exception);
 
   // Var() means call the object directly as a function rather than calling
   // a method in the object.
   cb.Call(Var(), Var(info), &exception);
 
   if (!exception.is_undefined()) {
-    LOG(WARNING) << "Exception when invoking debugInfo JS callback: "
-                 << exception.DebugString();
+    // Note that we cannot use LOG here because we're currently in the middle
+    // of handling a LOG message.

[Wez, 2011/08/30 05:20:02]

We've got a check that prevents recursive calling in to this function, so we can
LOG() here and it'll just go to the other log handlers, surely?

[garykac, 2011/08/31 00:59:00]

The previous checks didn't work because they were only protecting the post, not
the actual code that handled the log message.

The checks that are there need to be removed.

I'm creating a 2nd cl for client log cleanup and moving these changes into that
cl.

+    printf("Exception when invoking debugInfo JS callback: %s\n",
+           exception.DebugString());
   }
 }
 
 void ChromotingScriptableObject::SetDesktopSize(int width, int height) {
   int width_index = property_names_[kDesktopWidth];
   int height_index = property_names_[kDesktopHeight];
 
   if (properties_[width_index].attribute.AsInt() != width ||
       properties_[height_index].attribute.AsInt() != height) {
     properties_[width_index].attribute = Var(width);
@@ skipping 213 matching lines @@
     const std::vector<pp::Var>& args, pp::Var* exception) {
   if (args.size() != 0) {
     *exception = Var("Usage: DoReleaseAllKeys()");
     return Var();
   }
   instance_->ReleaseAllKeys();
   return Var();
 }
 
 }  // namespace remoting