Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1173)

Unified Diff: remoting/client/plugin/chromoting_instance.cc

Issue 7648042: Change Chromoting logger to be setup in plugin's NP_Initialize. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove comment Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/plugin/chromoting_instance.cc
diff --git a/remoting/client/plugin/chromoting_instance.cc b/remoting/client/plugin/chromoting_instance.cc
index bb4599f5d6e42abcc472f80cb43c6b641c2ab722..551ee06a085e7643e63ff8d672940657b7c2af75 100644
--- a/remoting/client/plugin/chromoting_instance.cc
+++ b/remoting/client/plugin/chromoting_instance.cc
@@ -438,12 +438,15 @@ bool ChromotingInstance::LogToUI(int severity, const char* file, int line,
}
}
+ // Call the next log handler in the chain.
if (g_logging_old_handler)
return (g_logging_old_handler)(severity, file, line, message_start, str);
return false;
}
void ChromotingInstance::ProcessLogToUI(const std::string& message) {
+ // |g_logging_to_plugin| is only referenced in this method and only on the
Wez 2011/08/30 05:20:02 nit: It's not relevant that it's only referenced h
garykac 2011/08/31 00:59:00 Actually, |g_logging_to_plugin| doesn't work as in
+ // main plugin thread, so we don't need a lock to access to it.
if (!g_logging_to_plugin) {
ChromotingScriptableObject* cso = GetScriptableObject();
if (cso) {

Powered by Google App Engine
This is Rietveld 408576698