Change Chromoting logger to be setup in plugin's NP_Initialize.

remoting/client/plugin/chromoting_instance.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/client/plugin/chromoting_instance.h"
 
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 420 matching lines @@
       std::string message = remoting::GetTimestampString();
       message += (str.c_str() + message_start);
       // |log_proxy_| is safe to use here because we detach the proxy before
       // tearing down the |g_logging_instance|.
       g_logging_instance->log_proxy_->Call(
           base::Bind(&ChromotingInstance::ProcessLogToUI,
                      base::Unretained(g_logging_instance), message));
     }
   }
 
+  // Call the next log handler in the chain.
   if (g_logging_old_handler)
     return (g_logging_old_handler)(severity, file, line, message_start, str);
   return false;
 }
 
 void ChromotingInstance::ProcessLogToUI(const std::string& message) {
+  // |g_logging_to_plugin| is only referenced in this method and only on the

[Wez, 2011/08/30 05:20:02]

nit: It's not relevant that it's only referenced here, I don't think?  Could
this check move inside LogDebugInfo?

[garykac, 2011/08/31 00:59:00]

Actually, |g_logging_to_plugin| doesn't work as intended and will be removed.
See separate client logging thread.

+  // main plugin thread, so we don't need a lock to access to it.
   if (!g_logging_to_plugin) {
     ChromotingScriptableObject* cso = GetScriptableObject();
     if (cso) {
       g_logging_to_plugin = true;
       cso->LogDebugInfo(message);
       g_logging_to_plugin = false;
     }
   }
 }
 
@@ skipping 90 matching lines @@
   }
 
   initial_policy_received_ = true;
   enable_client_nat_traversal_ = traversal_policy;
 
   if (delayed_connect_.get())
     plugin_message_loop_->PostTask(FROM_HERE, delayed_connect_.release());
 }
 
 }  // namespace remoting