Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Unified Diff: remoting/host/plugin/host_script_object.h

Issue 7648042: Change Chromoting logger to be setup in plugin's NP_Initialize. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/plugin/host_script_object.h
diff --git a/remoting/host/plugin/host_script_object.h b/remoting/host/plugin/host_script_object.h
index 03d14c32c32540bb39b95a67ab367cd0bba428af..539d92de49a46079fdefafc8f276aa9e4ae4587e 100644
--- a/remoting/host/plugin/host_script_object.h
+++ b/remoting/host/plugin/host_script_object.h
@@ -70,6 +70,12 @@ class HostNPScriptObject : public HostStatusObserver {
remoting::protocol::ConnectionToClient* client) OVERRIDE;
virtual void OnShutdown() OVERRIDE;
+ // Register/Unregister the log handler.
+ // These should be called from the plugin init/destroy methods so that they
+ // are only called once per plugin (not once per instance).
Wez 2011/08/16 00:05:45 nit: They need to be called once per plugin _proce
garykac 2011/08/16 00:19:40 Done.
+ static void RegisterLogger();
+ static void UnregisterLogger();
+
// A Log Message Handler that is called after each LOG message has been
// processed. This must be of type LogMessageHandlerFunction defined in
// base/logging.h.

Powered by Google App Engine
This is Rietveld 408576698