Change Chromoting logger to be setup in plugin's NP_Initialize.

remoting/host/plugin/host_script_object.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_HOST_PLUGIN_HOST_SCRIPT_OBJECT_H_
 #define REMOTING_HOST_PLUGIN_HOST_SCRIPT_OBJECT_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 52 matching lines @@
   virtual void OnSignallingConnected(remoting::SignalStrategy* signal_strategy,
                                      const std::string& full_jid) OVERRIDE;
   virtual void OnSignallingDisconnected() OVERRIDE;
   virtual void OnAccessDenied() OVERRIDE;
   virtual void OnClientAuthenticated(
       remoting::protocol::ConnectionToClient* client) OVERRIDE;
   virtual void OnClientDisconnected(
       remoting::protocol::ConnectionToClient* client) OVERRIDE;
   virtual void OnShutdown() OVERRIDE;
 
+  // Register/Unregister the log handler.
+  // These should be called from the plugin init/destroy methods so that they
+  // are only called once per plugin (not once per instance).

[Wez, 2011/08/16 00:05:45]

nit: They need to be called once per plugin _process_, rather than once per
plugin instance, since the loggers are process-global.

[garykac, 2011/08/16 00:19:40]

Done.

+  static void RegisterLogger();
+  static void UnregisterLogger();
+
   // A Log Message Handler that is called after each LOG message has been
   // processed. This must be of type LogMessageHandlerFunction defined in
   // base/logging.h.
   static bool LogToUI(int severity, const char* file, int line,
                       size_t message_start, const std::string& str);
  private:
   enum State {
     kDisconnected,
     kRequestedAccessCode,
     kReceivedAccessCode,
@@ skipping 68 matching lines @@
 
   base::WaitableEvent disconnected_event_;
   base::CancellationFlag destructing_;
 };
 
 }  // namespace remoting
 
 DISABLE_RUNNABLE_METHOD_REFCOUNT(remoting::HostNPScriptObject);
 
 #endif  // REMOTING_HOST_HOST_SCRIPT_OBJECT_H_