Issue 7648031: DevTools: Extension context menu does appear for selected text in the devtools of the devtools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7648031: DevTools: Extension context menu does appear for selected text in the devtools of the devtools. (Closed)

Created:
9 years, 4 months ago by pfeldman

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, yurys

CC:
chromium-reviews, Avi (use Gerrit), brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

DevTools: Extension context menu does appear for selected text in the devtools of the devtools. BUG=92824 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96798

Patch Set 1 #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	chrome/browser/tab_contents/render_view_context_menu.cc	View		2 chunks	+2 lines, -3 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

yurys

http://codereview.chromium.org/7648031/diff/1/chrome/browser/tab_contents/render_view_context_menu.cc File chrome/browser/tab_contents/render_view_context_menu.cc (right): http://codereview.chromium.org/7648031/diff/1/chrome/browser/tab_contents/render_view_context_menu.cc#newcode544 chrome/browser/tab_contents/render_view_context_menu.cc:544: if (!IsDevToolsURL(params_.page_url)) It doesn't take into account IsDevToolsURL(params_.frame_url) check ...

9 years, 4 months ago (2011-08-15 15:05:52 UTC) #1

Change committed as 96798

Expand Messages | Collapse Messages