Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5118)

Unified Diff: chrome/browser/tab_contents/render_view_context_menu.cc

Issue 7648031: DevTools: Extension context menu does appear for selected text in the devtools of the devtools. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/render_view_context_menu.cc
diff --git a/chrome/browser/tab_contents/render_view_context_menu.cc b/chrome/browser/tab_contents/render_view_context_menu.cc
index 2b07e36df4e2ad253cf062ba4381ac4c5c1d479e..c57e5ed5f359c1bc63254663ecab45b8c900314e 100644
--- a/chrome/browser/tab_contents/render_view_context_menu.cc
+++ b/chrome/browser/tab_contents/render_view_context_menu.cc
@@ -484,13 +484,12 @@ void RenderViewContextMenu::InitMenu() {
// When no special node or text is selected and selection has no link,
// show page items.
- bool is_devtools = false;
if (params_.media_type == WebContextMenuData::MediaTypeNone &&
!has_link &&
!params_.is_editable &&
!has_selection) {
if (!params_.page_url.is_empty()) {
- is_devtools = IsDevToolsURL(params_.page_url);
+ bool is_devtools = IsDevToolsURL(params_.page_url);
if (!is_devtools && !IsInternalResourcesURL(params_.page_url)) {
AppendPageItems();
// Merge in frame items if we clicked within a frame that needs them.
@@ -542,7 +541,7 @@ void RenderViewContextMenu::InitMenu() {
if (has_selection)
AppendSearchProvider();
- if (!is_devtools)
+ if (!IsDevToolsURL(params_.page_url))
yurys 2011/08/15 15:05:52 It doesn't take into account IsDevToolsURL(params_
AppendAllExtensionItems();
AppendDeveloperItems();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698