Issue 7647027: Return error not null for date time format.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7647027: Return error not null for date time format. (Closed)

Created:
9 years, 4 months ago by Nebojša Ćirić

Modified:
9 years, 4 months ago

Reviewers:
jungshik at Google

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Return error not null for date time format. BUG=v8:1602 TEST=new (new v8Locale().createDateTimeFormat()).getWeekdays should return Error not a Null. Committed: http://code.google.com/p/v8/source/detail?r=8935

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/extensions/experimental/datetime-format.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nebojša Ćirić

This API will probably disappear soon, but lets fix it.

9 years, 4 months ago (2011-08-15 20:32:22 UTC) #1

jungshik at Google

9 years, 4 months ago (2011-08-15 22:11:20 UTC) #2

On 2011/08/15 20:32:22, Nebojša Ćirić wrote:
> This API will probably disappear soon, but lets fix it.

LGTM. BTW, can you change the bug line to read

BUG=v8:1602

(then, linkifier will do the right thing (TM)).

Expand Messages | Collapse Messages