Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Side by Side Diff: src/extensions/experimental/datetime-format.cc

Issue 7647027: Return error not null for date time format. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 icu::DateFormatSymbols::STANDALONE, 128 icu::DateFormatSymbols::STANDALONE,
129 icu::DateFormatSymbols::WIDE); 129 icu::DateFormatSymbols::WIDE);
130 130
131 return GetSymbols( 131 return GetSymbols(
132 args, narrow, narrow_count, abbrev, abbrev_count, wide, wide_count); 132 args, narrow, narrow_count, abbrev, abbrev_count, wide, wide_count);
133 } 133 }
134 134
135 v8::Handle<v8::Value> DateTimeFormat::GetWeekdays(const v8::Arguments& args) { 135 v8::Handle<v8::Value> DateTimeFormat::GetWeekdays(const v8::Arguments& args) {
136 icu::SimpleDateFormat* date_format = UnpackDateTimeFormat(args.Holder()); 136 icu::SimpleDateFormat* date_format = UnpackDateTimeFormat(args.Holder());
137 if (!date_format) { 137 if (!date_format) {
138 ThrowUnexpectedObjectError(); 138 return ThrowUnexpectedObjectError();
139 } 139 }
140 140
141 const icu::DateFormatSymbols* symbols = date_format->getDateFormatSymbols(); 141 const icu::DateFormatSymbols* symbols = date_format->getDateFormatSymbols();
142 142
143 int32_t narrow_count; 143 int32_t narrow_count;
144 const icu::UnicodeString* narrow = symbols->getWeekdays( 144 const icu::UnicodeString* narrow = symbols->getWeekdays(
145 narrow_count, 145 narrow_count,
146 icu::DateFormatSymbols::STANDALONE, 146 icu::DateFormatSymbols::STANDALONE,
147 icu::DateFormatSymbols::NARROW); 147 icu::DateFormatSymbols::NARROW);
148 int32_t abbrev_count; 148 int32_t abbrev_count;
(...skipping 226 matching lines...) Expand 10 before | Expand all | Expand 10 after
375 } else if (type == UNICODE_STRING_SIMPLE("long")) { 375 } else if (type == UNICODE_STRING_SIMPLE("long")) {
376 return icu::DateFormat::kLong; 376 return icu::DateFormat::kLong;
377 } else if (type == UNICODE_STRING_SIMPLE("full")) { 377 } else if (type == UNICODE_STRING_SIMPLE("full")) {
378 return icu::DateFormat::kFull; 378 return icu::DateFormat::kFull;
379 } 379 }
380 380
381 return icu::DateFormat::kShort; 381 return icu::DateFormat::kShort;
382 } 382 }
383 383
384 } } // namespace v8::internal 384 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698