Issue 7646004: chromeos: Improve brightness and volume animations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7646004: chromeos: Improve brightness and volume animations. (Closed)

Created:
9 years, 4 months ago by Daniel Erat

Modified:
9 years, 4 months ago

Reviewers:
DaveMoore

CC:
chromium-reviews, Paweł Hajdan Jr., nkostylev+cc_chromium.org, davemoore+watch_chromium.org, dhollowa, Finnur, whywhat

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

chromeos: Improve brightness and volume animations. Make the onscreen brightness and volume indicators not be janky. Also change views::ProgressBar to permit specifying min and max double values, instead of just using a hardcoded integer range between 0 and 100. BUG=chromium-os:19141, chromium-os:8473 TEST=manual: held volume keys and checked that animation is smooth Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96853

Patch Set 1 #

Patch Set 2 : minor changes #

Patch Set 3 : hopefully fix windows compile and DCHECK #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+271 lines, -222 lines)			Patch
M	chrome/browser/chromeos/login/update_view.cc	View		5 chunks	+7 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/setting_level_bubble.h	View	1	5 chunks	+46 lines, -18 lines	0 comments	Download
M	chrome/browser/chromeos/setting_level_bubble.cc	View	1	8 chunks	+104 lines, -61 lines	0 comments	Download
M	chrome/browser/chromeos/setting_level_bubble_view.h	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/setting_level_bubble_view.cc	View		2 chunks	+5 lines, -8 lines	0 comments	Download
M	views/controls/progress_bar.h	View	1	1 chunk	+26 lines, -30 lines	0 comments	Download
M	views/controls/progress_bar.cc	View	1 2	12 chunks	+76 lines, -71 lines	0 comments	Download
M	views/controls/progress_bar_unittest.cc	View		3 chunks	+2 lines, -26 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages