Autofill: Check for different string sizes when comparing for equality.

Autofill: Check for different string sizes when comparing for equality.

Also uses StringToLowerASCII for consistency with AF code. Fixes a crash under Win Dbg.

BUG=92937
TEST=WebDatabaseMigrationTest.MigrateVersion32ToCurrent

R=dhollowa@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97108

[dhollowa, 2011-08-15 21:45:15]

http://codereview.chromium.org/7645038/diff/1/chrome/browser/autofill/autofil...
File chrome/browser/autofill/autofill_profile.cc (right):

http://codereview.chromium.org/7645038/diff/1/chrome/browser/autofill/autofil...
chrome/browser/autofill/autofill_profile.cc:546: if (x.size() != y.size())
return false;
Elsewhere in the Autofill code we're using |StringToLowerASCII|.

[James Hawkins, 2011-08-15 21:57:11]

http://codereview.chromium.org/7645038/diff/1/chrome/browser/autofill/autofil...
File chrome/browser/autofill/autofill_profile.cc (right):

http://codereview.chromium.org/7645038/diff/1/chrome/browser/autofill/autofil...
chrome/browser/autofill/autofill_profile.cc:546: if (x.size() != y.size())
return false;
On 2011/08/15 21:45:15, dhollowa wrote:
> Elsewhere in the Autofill code we're using |StringToLowerASCII|.

Done.

[dhollowa, 2011-08-15 21:57:52]

LGTM.

[Ilya Sherman, 2011-08-17 00:58:55]

http://codereview.chromium.org/7645038/diff/4001/chrome/browser/autofill/auto...
File chrome/browser/autofill/autofill_profile.cc (right):

http://codereview.chromium.org/7645038/diff/4001/chrome/browser/autofill/auto...
chrome/browser/autofill/autofill_profile.cc:546: if (x.size() != y.size())
return false;
nit: The size check isn't actually necessary if using StringToLowerASCII and
operator==(), right?

[commit-bot: I haz the power, 2011-08-17 06:37:47]

Change committed as 97108