Autofill: Check for different string sizes when comparing for equality.

chrome/browser/autofill/autofill_profile.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autofill/autofill_profile.h"
 
 #include <algorithm>
 #include <functional>
 #include <map>
 #include <set>
@@ skipping 525 matching lines @@
 const string16 AutofillProfile::PrimaryValue() const {
   return GetInfo(ADDRESS_HOME_LINE1) +
          GetInfo(ADDRESS_HOME_CITY);
 }
 
 // Functor used to check for case-insensitive equality of two strings.
 struct CaseInsensitiveStringEquals
     : public std::binary_function<string16, string16, bool>
 {
   bool operator()(const string16& x, const string16& y) const {
+    if (x.size() != y.size()) return false;

[dhollowa, 2011/08/15 21:45:15]

Elsewhere in the Autofill code we're using |StringToLowerASCII|.

[James Hawkins, 2011/08/15 21:57:11]

Done.

     return std::equal(x.begin(), x.end(), y.begin(),
                       base::CaseInsensitiveCompare<string16::value_type>());
   }
 };
 
 void AutofillProfile::OverwriteWithOrAddTo(const AutofillProfile& profile) {
   FieldTypeSet field_types;
   profile.GetNonEmptyTypes(&field_types);
 
   // Only transfer "full" types (e.g. full name) and not fragments (e.g.
@@ skipping 218 matching lines @@
       << UTF16ToUTF8(profile.GetInfo(ADDRESS_HOME_STATE))
       << " "
       << UTF16ToUTF8(profile.GetInfo(ADDRESS_HOME_ZIP))
       << " "
       << UTF16ToUTF8(profile.GetInfo(ADDRESS_HOME_COUNTRY))
       << " "
       << UTF16ToUTF8(MultiString(profile, PHONE_HOME_WHOLE_NUMBER))
       << " "
       << UTF16ToUTF8(MultiString(profile, PHONE_FAX_WHOLE_NUMBER));
 }