chrome/browser/chromeos/login/webui_login_view.h - Issue 7640023: [ChromeOS] WebUILoginView returns true for IsPopupOrPanel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/webui_login_view.h

Issue 7640023: [ChromeOS] WebUILoginView returns true for IsPopupOrPanel. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/login/webui_login_view.h

diff --git a/chrome/browser/chromeos/login/webui_login_view.h b/chrome/browser/chromeos/login/webui_login_view.h

index 2c5b13b004ef7051fdbb43153d2bce3b12eac84a..c07de5953a6076a23ff63c39fc6dc4518607b582 100644

--- a/chrome/browser/chromeos/login/webui_login_view.h

+++ b/chrome/browser/chromeos/login/webui_login_view.h

@@ -110,8 +110,9 @@ class WebUILoginView : public views::View,

// Overridden from TabContentsDelegate.

virtual bool HandleContextMenu(const ContextMenuParams& params) OVERRIDE;

- virtual bool TakeFocus(bool reverse) OVERRIDE;

virtual void HandleKeyboardEvent(const NativeWebKeyboardEvent& event);

achuithb 2011/08/12 18:34:49 Also OVERRIDE?

xiyuan 2011/08/12 19:32:56 Done.

+ virtual bool IsPopupOrPanel(const TabContents* source) const OVERRIDE;

+ virtual bool TakeFocus(bool reverse) OVERRIDE;

// Window that contains status area.

// TODO(nkostylev): Temporary solution till we have

« no previous file with comments | « no previous file | chrome/browser/chromeos/login/webui_login_view.cc » ('j') | no next file with comments »