Add OVERRIDEs to RenderViewHostObserver subclasses that didn't already have them.

Add OVERRIDEs to RenderViewHostObserver subclasses that didn't already have them.

R=jam@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96522

[jam, 2011-08-11 22:40:55]

lgtm

nit

BUG=none
TEST=no

aren't needed. BUG is when there's an associated bug, and if there aren't any,
the lack of BUG= is enough to signify that. TEST is instructions for manual
testers. If there's nothing to tell them, then it's not needed.

[Mihai Parparita -not on Chrome, 2011-08-11 22:43:26]

On Thu, Aug 11, 2011 at 3:40 PM,  <jam@chromium.org> wrote:
> nit
>
> BUG=none
> TEST=no
>
> aren't needed. BUG is when there's an associated bug, and if there aren't
> any,
> the lack of BUG= is enough to signify that. TEST is instructions for manual
> testers. If there's nothing to tell them, then it's not needed.

Thanks for the tip. I have some vague recollection of the presubmit
script warning if they're missing, but perhaps things are different
now.

Mihai

[jam, 2011-08-11 23:10:23]

On Thu, Aug 11, 2011 at 3:42 PM, Mihai Parparita <mihaip@chromium.org>wrote:

> On Thu, Aug 11, 2011 at 3:40 PM,  <jam@chromium.org> wrote:
> > nit
> >
> > BUG=none
> > TEST=no
> >
> > aren't needed. BUG is when there's an associated bug, and if there aren't
> > any,
> > the lack of BUG= is enough to signify that. TEST is instructions for
> manual
> > testers. If there's nothing to tell them, then it's not needed.
>
> Thanks for the tip. I have some vague recollection of the presubmit
> script warning if they're missing, but perhaps things are different
> now.
>

Yep it used to always ask for it :) Now it suggests adding them when they're
necessary.

>
> Mihai
>

[commit-bot: I haz the power, 2011-08-12 07:08:27]

Change committed as 96522