Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: chrome/browser/extensions/extension_message_handler.h

Issue 7635006: Add OVERRIDEs to RenderViewHostObserver subclasses that didn't already have them. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/renderer_host/render_widget_host_view_mac.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_MESSAGE_HANDLER_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_MESSAGE_HANDLER_H_
6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_MESSAGE_HANDLER_H_ 6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_MESSAGE_HANDLER_H_
7 #pragma once 7 #pragma once
8 8
9 #include "content/browser/renderer_host/render_view_host_observer.h" 9 #include "content/browser/renderer_host/render_view_host_observer.h"
10 10
11 class Profile; 11 class Profile;
12 struct ExtensionHostMsg_DomMessage_Params; 12 struct ExtensionHostMsg_DomMessage_Params;
13 13
14 // Filters and dispatches extension-related IPC messages that arrive from 14 // Filters and dispatches extension-related IPC messages that arrive from
15 // renderers. There is one of these objects for each RenderViewHost in Chrome. 15 // renderers. There is one of these objects for each RenderViewHost in Chrome.
16 // Contrast this with ExtensionTabHelper, which is only created for TabContents. 16 // Contrast this with ExtensionTabHelper, which is only created for TabContents.
17 // 17 //
18 // TODO(aa): Handling of content script messaging should be able to move to EFD 18 // TODO(aa): Handling of content script messaging should be able to move to EFD
19 // once there is an EFD for every RVHD where extension code can run. Then we 19 // once there is an EFD for every RVHD where extension code can run. Then we
20 // could eliminate this class. Right now, we don't end up with an EFD for tab 20 // could eliminate this class. Right now, we don't end up with an EFD for tab
21 // contents unless that tab contents is hosting chrome-extension:// URLs. That 21 // contents unless that tab contents is hosting chrome-extension:// URLs. That
22 // still leaves content scripts. See also: crbug.com/80307. 22 // still leaves content scripts. See also: crbug.com/80307.
23 class ExtensionMessageHandler : public RenderViewHostObserver { 23 class ExtensionMessageHandler : public RenderViewHostObserver {
24 public: 24 public:
25 // |sender| is guaranteed to outlive this object. 25 // |sender| is guaranteed to outlive this object.
26 explicit ExtensionMessageHandler(RenderViewHost* render_view_host); 26 explicit ExtensionMessageHandler(RenderViewHost* render_view_host);
27 virtual ~ExtensionMessageHandler(); 27 virtual ~ExtensionMessageHandler();
28 28
29 // RenderViewHostObserver overrides. 29 // RenderViewHostObserver overrides.
30 virtual void RenderViewHostInitialized(); 30 virtual void RenderViewHostInitialized() OVERRIDE;
31 virtual bool OnMessageReceived(const IPC::Message& message); 31 virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
32 32
33 private: 33 private:
34 // Message handlers. 34 // Message handlers.
35 void OnPostMessage(int port_id, const std::string& message); 35 void OnPostMessage(int port_id, const std::string& message);
36 36
37 DISALLOW_COPY_AND_ASSIGN(ExtensionMessageHandler); 37 DISALLOW_COPY_AND_ASSIGN(ExtensionMessageHandler);
38 }; 38 };
39 39
40 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_MESSAGE_HANDLER_H_ 40 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_MESSAGE_HANDLER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/renderer_host/render_widget_host_view_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698